Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: chrome/browser/browser_process_impl.h

Issue 8609010: Make DevToolsManager a singleton, remove it from ContentBrowserClient (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Reverted notification service changes, use non-leaky singleton Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/browser_process.h ('k') | chrome/browser/browser_process_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // When each service is created, we set a flag indicating this. At this point, 5 // When each service is created, we set a flag indicating this. At this point,
6 // the service initialization could fail or succeed. This allows us to remember 6 // the service initialization could fail or succeed. This allows us to remember
7 // if we tried to create a service, and not try creating it over and over if 7 // if we tried to create a service, and not try creating it over and over if
8 // the creation failed. 8 // the creation failed.
9 9
10 #ifndef CHROME_BROWSER_BROWSER_PROCESS_IMPL_H_ 10 #ifndef CHROME_BROWSER_BROWSER_PROCESS_IMPL_H_
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 virtual IOThread* io_thread() OVERRIDE; 54 virtual IOThread* io_thread() OVERRIDE;
55 virtual base::Thread* file_thread() OVERRIDE; 55 virtual base::Thread* file_thread() OVERRIDE;
56 virtual base::Thread* db_thread() OVERRIDE; 56 virtual base::Thread* db_thread() OVERRIDE;
57 virtual base::Thread* cache_thread() OVERRIDE; 57 virtual base::Thread* cache_thread() OVERRIDE;
58 virtual WatchDogThread* watchdog_thread() OVERRIDE; 58 virtual WatchDogThread* watchdog_thread() OVERRIDE;
59 #if defined(OS_CHROMEOS) 59 #if defined(OS_CHROMEOS)
60 virtual base::Thread* web_socket_proxy_thread() OVERRIDE; 60 virtual base::Thread* web_socket_proxy_thread() OVERRIDE;
61 #endif 61 #endif
62 virtual ProfileManager* profile_manager() OVERRIDE; 62 virtual ProfileManager* profile_manager() OVERRIDE;
63 virtual PrefService* local_state() OVERRIDE; 63 virtual PrefService* local_state() OVERRIDE;
64 virtual DevToolsManager* devtools_manager() OVERRIDE;
65 virtual SidebarManager* sidebar_manager() OVERRIDE; 64 virtual SidebarManager* sidebar_manager() OVERRIDE;
66 virtual ui::Clipboard* clipboard() OVERRIDE; 65 virtual ui::Clipboard* clipboard() OVERRIDE;
67 virtual net::URLRequestContextGetter* system_request_context() OVERRIDE; 66 virtual net::URLRequestContextGetter* system_request_context() OVERRIDE;
68 #if defined(OS_CHROMEOS) 67 #if defined(OS_CHROMEOS)
69 virtual browser::OomPriorityManager* oom_priority_manager() OVERRIDE; 68 virtual browser::OomPriorityManager* oom_priority_manager() OVERRIDE;
70 #endif // defined(OS_CHROMEOS) 69 #endif // defined(OS_CHROMEOS)
71 virtual ExtensionEventRouterForwarder* 70 virtual ExtensionEventRouterForwarder*
72 extension_event_router_forwarder() OVERRIDE; 71 extension_event_router_forwarder() OVERRIDE;
73 virtual NotificationUIManager* notification_ui_manager() OVERRIDE; 72 virtual NotificationUIManager* notification_ui_manager() OVERRIDE;
74 virtual policy::BrowserPolicyConnector* browser_policy_connector() OVERRIDE; 73 virtual policy::BrowserPolicyConnector* browser_policy_connector() OVERRIDE;
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 void CreateWatchdogThread(); 133 void CreateWatchdogThread();
135 #if defined(OS_CHROMEOS) 134 #if defined(OS_CHROMEOS)
136 void CreateWebSocketProxyThread(); 135 void CreateWebSocketProxyThread();
137 #endif 136 #endif
138 void CreateTemplateURLService(); 137 void CreateTemplateURLService();
139 void CreateProfileManager(); 138 void CreateProfileManager();
140 void CreateWebDataService(); 139 void CreateWebDataService();
141 void CreateLocalState(); 140 void CreateLocalState();
142 void CreateViewedPageTracker(); 141 void CreateViewedPageTracker();
143 void CreateIconManager(); 142 void CreateIconManager();
144 void CreateDevToolsManager();
145 void CreateSidebarManager(); 143 void CreateSidebarManager();
146 void CreateGoogleURLTracker(); 144 void CreateGoogleURLTracker();
147 void CreateIntranetRedirectDetector(); 145 void CreateIntranetRedirectDetector();
148 void CreateNotificationUIManager(); 146 void CreateNotificationUIManager();
149 void CreateStatusTrayManager(); 147 void CreateStatusTrayManager();
150 void CreateTabCloseableStateWatcher(); 148 void CreateTabCloseableStateWatcher();
151 void CreatePrintPreviewTabController(); 149 void CreatePrintPreviewTabController();
152 void CreateBackgroundPrintingManager(); 150 void CreateBackgroundPrintingManager();
153 void CreateSafeBrowsingService(); 151 void CreateSafeBrowsingService();
154 void CreateSafeBrowsingDetectionService(); 152 void CreateSafeBrowsingDetectionService();
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 bool created_icon_manager_; 195 bool created_icon_manager_;
198 scoped_ptr<IconManager> icon_manager_; 196 scoped_ptr<IconManager> icon_manager_;
199 197
200 scoped_refptr<ExtensionEventRouterForwarder> 198 scoped_refptr<ExtensionEventRouterForwarder>
201 extension_event_router_forwarder_; 199 extension_event_router_forwarder_;
202 200
203 scoped_ptr<RemoteDebuggingServer> remote_debugging_server_; 201 scoped_ptr<RemoteDebuggingServer> remote_debugging_server_;
204 202
205 scoped_refptr<DevToolsProtocolHandler> devtools_legacy_handler_; 203 scoped_refptr<DevToolsProtocolHandler> devtools_legacy_handler_;
206 204
207 bool created_devtools_manager_;
208 scoped_ptr<DevToolsManager> devtools_manager_;
209
210 bool created_sidebar_manager_; 205 bool created_sidebar_manager_;
211 scoped_refptr<SidebarManager> sidebar_manager_; 206 scoped_refptr<SidebarManager> sidebar_manager_;
212 207
213 bool created_browser_policy_connector_; 208 bool created_browser_policy_connector_;
214 scoped_ptr<policy::BrowserPolicyConnector> browser_policy_connector_; 209 scoped_ptr<policy::BrowserPolicyConnector> browser_policy_connector_;
215 210
216 scoped_refptr<printing::PrintPreviewTabController> 211 scoped_refptr<printing::PrintPreviewTabController>
217 print_preview_tab_controller_; 212 print_preview_tab_controller_;
218 213
219 scoped_ptr<printing::BackgroundPrintingManager> background_printing_manager_; 214 scoped_ptr<printing::BackgroundPrintingManager> background_printing_manager_;
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
303 #if !defined(OS_CHROMEOS) 298 #if !defined(OS_CHROMEOS)
304 scoped_ptr<ComponentUpdateService> component_updater_; 299 scoped_ptr<ComponentUpdateService> component_updater_;
305 300
306 scoped_refptr<CRLSetFetcher> crl_set_fetcher_; 301 scoped_refptr<CRLSetFetcher> crl_set_fetcher_;
307 #endif 302 #endif
308 303
309 DISALLOW_COPY_AND_ASSIGN(BrowserProcessImpl); 304 DISALLOW_COPY_AND_ASSIGN(BrowserProcessImpl);
310 }; 305 };
311 306
312 #endif // CHROME_BROWSER_BROWSER_PROCESS_IMPL_H_ 307 #endif // CHROME_BROWSER_BROWSER_PROCESS_IMPL_H_
OLDNEW
« no previous file with comments | « chrome/browser/browser_process.h ('k') | chrome/browser/browser_process_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698