Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8416020: Handle additional feedback from http://codereview.chromium.org/8395038/. (Closed)

Created:
9 years, 1 month ago by jam
Modified:
9 years, 1 month ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, Raghu Simha, jam, ncarter (slow), dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, tim (not reviewing), Paweł Hajdan Jr., James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, akalin
Visibility:
Public.

Description

Handle additional feedback from http://codereview.chromium.org/8395038/. -rename URLFetcherFactory to URLFetcherImplFactory -rename GetUrl to GetURL and GetOriginalUrl to GetOriginalURL -get rid of request_type in TestURLFetcher's constructor BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107665

Patch Set 1 : '' #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -135 lines) Patch
M chrome/browser/alternate_nav_url_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/search_provider_unittest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/autofill/autofill_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bug_report_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/customization_document.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/cookie_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/image_downloader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/mock_auth_response_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/mock_url_fetchers.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/profile_image_downloader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_updater.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_updater_unittest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/intranet_redirect_detector.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/net/gaia/gaia_oauth_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/gaia/gaia_oauth_fetcher_unittest.cc View 1 4 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/net/sdch_dictionary_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugin_download_helper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/device_management_service_unittest.cc View 1 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/policy/testing_policy_url_fetcher_factory.cc View 4 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/malware_details_cache.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_manager.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/http_bridge_unittest.cc View 1 2 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_manager_browsertest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/net/gaia/gaia_auth_fetcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/net/gaia/gaia_auth_fetcher_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/net/gaia/gaia_oauth_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_url_fetcher.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/geolocation/network_location_provider_unittest.cc View 1 7 chunks +9 lines, -9 lines 0 comments Download
M content/browser/geolocation/network_location_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/speech/speech_recognition_request_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/speech/speech_recognizer_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/common/net/url_fetcher_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/net/url_fetcher_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/url_fetcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/test_url_fetcher_factory.h View 6 chunks +12 lines, -13 lines 1 comment Download
M content/test/test_url_fetcher_factory.cc View 7 chunks +13 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
9 years, 1 month ago (2011-10-27 22:34:17 UTC) #1
wtc
9 years, 1 month ago (2011-10-27 23:56:50 UTC) #2 
LGTM.  Thanks!

http://codereview.chromium.org/8416020/diff/5016/content/test/test_url_fetche...
File content/test/test_url_fetcher_factory.h (right):

http://codereview.chromium.org/8416020/diff/5016/content/test/test_url_fetche...
content/test/test_url_fetcher_factory.h:53: // might want to use the
FakeUrlFetcher and FakeUrlFetcherFactory classes

Fix these two typos: FakeUrlFetcher and FakeUrlFetcherFactory

Powered by Google App Engine
This is Rietveld 408576698