Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Side by Side Diff: chrome/browser/net/gaia/gaia_oauth_fetcher_unittest.cc

Issue 8416020: Handle additional feedback from http://codereview.chromium.org/8395038/. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // A complete set of unit tests for GaiaOAuthFetcher. 5 // A complete set of unit tests for GaiaOAuthFetcher.
6 // Originally ported from GaiaAuthFetcher tests. 6 // Originally ported from GaiaAuthFetcher tests.
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 EXPECT_CALL(oauth_fetcher, 153 EXPECT_CALL(oauth_fetcher,
154 StartOAuthWrapBridge(oauth_token, 154 StartOAuthWrapBridge(oauth_token,
155 oauth_token_secret, 155 oauth_token_secret,
156 "3600", 156 "3600",
157 "service_scope-JnG18MEE")).Times(1); 157 "service_scope-JnG18MEE")).Times(1);
158 158
159 net::ResponseCookies cookies; 159 net::ResponseCookies cookies;
160 net::URLRequestStatus status(net::URLRequestStatus::SUCCESS, 0); 160 net::URLRequestStatus status(net::URLRequestStatus::SUCCESS, 0);
161 GURL url(GaiaUrls::GetInstance()->oauth_get_access_token_url()); 161 GURL url(GaiaUrls::GetInstance()->oauth_get_access_token_url());
162 162
163 TestURLFetcher test_fetcher( 163 TestURLFetcher test_fetcher(0, GURL(), &oauth_fetcher);
164 0, GURL(), content::URLFetcher::GET, &oauth_fetcher);
165 test_fetcher.set_url(url); 164 test_fetcher.set_url(url);
166 test_fetcher.set_status(status); 165 test_fetcher.set_status(status);
167 test_fetcher.set_response_code(RC_REQUEST_OK); 166 test_fetcher.set_response_code(RC_REQUEST_OK);
168 test_fetcher.set_cookies(cookies); 167 test_fetcher.set_cookies(cookies);
169 test_fetcher.SetResponseString(data); 168 test_fetcher.SetResponseString(data);
170 oauth_fetcher.OnURLFetchComplete(&test_fetcher); 169 oauth_fetcher.OnURLFetchComplete(&test_fetcher);
171 } 170 }
172 171
173 TEST_F(GaiaOAuthFetcherTest, OAuthWrapBridge) { 172 TEST_F(GaiaOAuthFetcherTest, OAuthWrapBridge) {
174 const std::string wrap_token = 173 const std::string wrap_token =
(...skipping 14 matching lines...) Expand all
189 MockGaiaOAuthFetcher oauth_fetcher(&consumer, 188 MockGaiaOAuthFetcher oauth_fetcher(&consumer,
190 profile.GetRequestContext(), 189 profile.GetRequestContext(),
191 &profile, 190 &profile,
192 "service_scope-0fL85iOi"); 191 "service_scope-0fL85iOi");
193 EXPECT_CALL(oauth_fetcher, StartUserInfo(wrap_token)).Times(1); 192 EXPECT_CALL(oauth_fetcher, StartUserInfo(wrap_token)).Times(1);
194 193
195 net::ResponseCookies cookies; 194 net::ResponseCookies cookies;
196 net::URLRequestStatus status(net::URLRequestStatus::SUCCESS, 0); 195 net::URLRequestStatus status(net::URLRequestStatus::SUCCESS, 0);
197 GURL url(GaiaUrls::GetInstance()->oauth_wrap_bridge_url()); 196 GURL url(GaiaUrls::GetInstance()->oauth_wrap_bridge_url());
198 197
199 TestURLFetcher test_fetcher( 198 TestURLFetcher test_fetcher(0, GURL(), &oauth_fetcher);
200 0, GURL(), content::URLFetcher::GET, &oauth_fetcher);
201 test_fetcher.set_url(url); 199 test_fetcher.set_url(url);
202 test_fetcher.set_status(status); 200 test_fetcher.set_status(status);
203 test_fetcher.set_response_code(RC_REQUEST_OK); 201 test_fetcher.set_response_code(RC_REQUEST_OK);
204 test_fetcher.set_cookies(cookies); 202 test_fetcher.set_cookies(cookies);
205 test_fetcher.SetResponseString(data); 203 test_fetcher.SetResponseString(data);
206 oauth_fetcher.OnURLFetchComplete(&test_fetcher); 204 oauth_fetcher.OnURLFetchComplete(&test_fetcher);
207 } 205 }
208 206
209 TEST_F(GaiaOAuthFetcherTest, UserInfo) { 207 TEST_F(GaiaOAuthFetcherTest, UserInfo) {
210 const std::string email_address = "someone@somewhere.net"; 208 const std::string email_address = "someone@somewhere.net";
211 const std::string wrap_token = 209 const std::string wrap_token =
212 "1/OAuth2-Access_Token-nopqrstuvwxyz1234567890"; 210 "1/OAuth2-Access_Token-nopqrstuvwxyz1234567890";
213 const std::string expires_in = "3600"; 211 const std::string expires_in = "3600";
214 const std::string data("{\n \"email\": \"someone@somewhere.net\",\n" 212 const std::string data("{\n \"email\": \"someone@somewhere.net\",\n"
215 " \"verified_email\": true\n}\n"); 213 " \"verified_email\": true\n}\n");
216 MockGaiaOAuthConsumer consumer; 214 MockGaiaOAuthConsumer consumer;
217 EXPECT_CALL(consumer, 215 EXPECT_CALL(consumer,
218 OnUserInfoSuccess(email_address)).Times(1); 216 OnUserInfoSuccess(email_address)).Times(1);
219 217
220 TestingProfile profile; 218 TestingProfile profile;
221 MockGaiaOAuthFetcher oauth_fetcher(&consumer, 219 MockGaiaOAuthFetcher oauth_fetcher(&consumer,
222 profile.GetRequestContext(), 220 profile.GetRequestContext(),
223 &profile, 221 &profile,
224 "service_scope-Nrj4LmgU"); 222 "service_scope-Nrj4LmgU");
225 223
226 net::ResponseCookies cookies; 224 net::ResponseCookies cookies;
227 net::URLRequestStatus status(net::URLRequestStatus::SUCCESS, 0); 225 net::URLRequestStatus status(net::URLRequestStatus::SUCCESS, 0);
228 GURL url(GaiaUrls::GetInstance()->oauth_user_info_url()); 226 GURL url(GaiaUrls::GetInstance()->oauth_user_info_url());
229 227
230 TestURLFetcher test_fetcher( 228 TestURLFetcher test_fetcher(0, GURL(), &oauth_fetcher);
231 0, GURL(), content::URLFetcher::GET, &oauth_fetcher);
232 test_fetcher.set_url(url); 229 test_fetcher.set_url(url);
233 test_fetcher.set_status(status); 230 test_fetcher.set_status(status);
234 test_fetcher.set_response_code(RC_REQUEST_OK); 231 test_fetcher.set_response_code(RC_REQUEST_OK);
235 test_fetcher.set_cookies(cookies); 232 test_fetcher.set_cookies(cookies);
236 test_fetcher.SetResponseString(data); 233 test_fetcher.SetResponseString(data);
237 oauth_fetcher.OnURLFetchComplete(&test_fetcher); 234 oauth_fetcher.OnURLFetchComplete(&test_fetcher);
238 } 235 }
239 236
240 TEST_F(GaiaOAuthFetcherTest, OAuthRevokeToken) { 237 TEST_F(GaiaOAuthFetcherTest, OAuthRevokeToken) {
241 const std::string token = "1/OAuth2-Access_Token-nopqrstuvwxyz1234567890"; 238 const std::string token = "1/OAuth2-Access_Token-nopqrstuvwxyz1234567890";
242 MockGaiaOAuthConsumer consumer; 239 MockGaiaOAuthConsumer consumer;
243 EXPECT_CALL(consumer, 240 EXPECT_CALL(consumer,
244 OnOAuthRevokeTokenSuccess()).Times(1); 241 OnOAuthRevokeTokenSuccess()).Times(1);
245 242
246 TestingProfile profile; 243 TestingProfile profile;
247 MockGaiaOAuthFetcher oauth_fetcher(&consumer, 244 MockGaiaOAuthFetcher oauth_fetcher(&consumer,
248 profile.GetRequestContext(), 245 profile.GetRequestContext(),
249 &profile, 246 &profile,
250 "service_scope-Nrj4LmgU"); 247 "service_scope-Nrj4LmgU");
251 248
252 net::ResponseCookies cookies; 249 net::ResponseCookies cookies;
253 net::URLRequestStatus status(net::URLRequestStatus::SUCCESS, 0); 250 net::URLRequestStatus status(net::URLRequestStatus::SUCCESS, 0);
254 GURL url(GaiaUrls::GetInstance()->oauth_revoke_token_url()); 251 GURL url(GaiaUrls::GetInstance()->oauth_revoke_token_url());
255 252
256 TestURLFetcher test_fetcher( 253 TestURLFetcher test_fetcher(0, GURL(), &oauth_fetcher);
257 0, GURL(), content::URLFetcher::GET, &oauth_fetcher);
258 test_fetcher.set_url(url); 254 test_fetcher.set_url(url);
259 test_fetcher.set_status(status); 255 test_fetcher.set_status(status);
260 test_fetcher.set_response_code(RC_REQUEST_OK); 256 test_fetcher.set_response_code(RC_REQUEST_OK);
261 test_fetcher.set_cookies(cookies); 257 test_fetcher.set_cookies(cookies);
262 oauth_fetcher.OnURLFetchComplete(&test_fetcher); 258 oauth_fetcher.OnURLFetchComplete(&test_fetcher);
263 } 259 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698