chrome/browser/net/gaia/gaia_oauth_fetcher_unittest.cc - Issue 8416020: Handle additional feedback from http://codereview.chromium.org/8395038/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/gaia/gaia_oauth_fetcher_unittest.cc

Issue 8416020: Handle additional feedback from http://codereview.chromium.org/8395038/. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/net/gaia/gaia_oauth_fetcher.cc ('k') | chrome/browser/net/sdch_dictionary_fetcher.cc » ('j') | content/test/test_url_fetcher_factory.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/gaia/gaia_oauth_fetcher_unittest.cc

===================================================================

--- chrome/browser/net/gaia/gaia_oauth_fetcher_unittest.cc (revision 107626)

+++ chrome/browser/net/gaia/gaia_oauth_fetcher_unittest.cc (working copy)

@@ -160,8 +160,7 @@

net::URLRequestStatus status(net::URLRequestStatus::SUCCESS, 0);

GURL url(GaiaUrls::GetInstance()->oauth_get_access_token_url());

- TestURLFetcher test_fetcher(

- 0, GURL(), content::URLFetcher::GET, &oauth_fetcher);

+ TestURLFetcher test_fetcher(0, GURL(), &oauth_fetcher);

test_fetcher.set_url(url);

test_fetcher.set_status(status);

test_fetcher.set_response_code(RC_REQUEST_OK);

@@ -196,8 +195,7 @@

net::URLRequestStatus status(net::URLRequestStatus::SUCCESS, 0);

GURL url(GaiaUrls::GetInstance()->oauth_wrap_bridge_url());

- TestURLFetcher test_fetcher(

- 0, GURL(), content::URLFetcher::GET, &oauth_fetcher);

+ TestURLFetcher test_fetcher(0, GURL(), &oauth_fetcher);

test_fetcher.set_url(url);

test_fetcher.set_status(status);

test_fetcher.set_response_code(RC_REQUEST_OK);

@@ -227,8 +225,7 @@

net::URLRequestStatus status(net::URLRequestStatus::SUCCESS, 0);

GURL url(GaiaUrls::GetInstance()->oauth_user_info_url());

- TestURLFetcher test_fetcher(

- 0, GURL(), content::URLFetcher::GET, &oauth_fetcher);

+ TestURLFetcher test_fetcher(0, GURL(), &oauth_fetcher);

test_fetcher.set_url(url);

test_fetcher.set_status(status);

test_fetcher.set_response_code(RC_REQUEST_OK);

@@ -253,8 +250,7 @@

net::URLRequestStatus status(net::URLRequestStatus::SUCCESS, 0);

GURL url(GaiaUrls::GetInstance()->oauth_revoke_token_url());

- TestURLFetcher test_fetcher(

- 0, GURL(), content::URLFetcher::GET, &oauth_fetcher);

+ TestURLFetcher test_fetcher(0, GURL(), &oauth_fetcher);

test_fetcher.set_url(url);

test_fetcher.set_status(status);

test_fetcher.set_response_code(RC_REQUEST_OK);

« no previous file with comments | « chrome/browser/net/gaia/gaia_oauth_fetcher.cc ('k') | chrome/browser/net/sdch_dictionary_fetcher.cc » ('j') | content/test/test_url_fetcher_factory.h » ('J')