chrome/browser/policy/testing_policy_url_fetcher_factory.cc - Issue 8416020: Handle additional feedback from http://codereview.chromium.org/8395038/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/testing_policy_url_fetcher_factory.cc

Issue 8416020: Handle additional feedback from http://codereview.chromium.org/8395038/. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/policy/device_management_service_unittest.cc ('k') | chrome/browser/safe_browsing/client_side_detection_service.cc » ('j') | content/test/test_url_fetcher_factory.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/testing_policy_url_fetcher_factory.cc

===================================================================

--- chrome/browser/policy/testing_policy_url_fetcher_factory.cc (revision 107626)

+++ chrome/browser/policy/testing_policy_url_fetcher_factory.cc (working copy)

@@ -39,7 +39,6 @@

TestingPolicyURLFetcher(

const base::WeakPtr<TestingPolicyURLFetcherFactory>& parent,

const GURL& url,

- content::URLFetcher::RequestType request_type,

content::URLFetcherDelegate* delegate);

virtual void Start() OVERRIDE;

@@ -65,9 +64,8 @@

TestingPolicyURLFetcher::TestingPolicyURLFetcher(

const base::WeakPtr<TestingPolicyURLFetcherFactory>& parent,

const GURL& url,

- content::URLFetcher::RequestType request_type,

content::URLFetcherDelegate* delegate)

- : TestURLFetcher(0, url, request_type, delegate),

+ : TestURLFetcher(0, url, delegate),

parent_(parent) {

set_url(url);

set_status(net::URLRequestStatus(net::URLRequestStatus::SUCCESS, 0));

@@ -78,7 +76,7 @@

std::string auth_header;

net::HttpRequestHeaders headers;

- std::string request = GetRequestType(GetUrl());

+ std::string request = GetRequestType(GetURL());

GetExtraRequestHeaders(&headers);

headers.GetHeader("Authorization", &auth_header);

// The following method is mocked by the currently running test.

@@ -124,7 +122,7 @@

content::URLFetcher::RequestType request_type,

content::URLFetcherDelegate* delegate) {

return new TestingPolicyURLFetcher(

- weak_ptr_factory_.GetWeakPtr(), url, request_type, delegate);

+ weak_ptr_factory_.GetWeakPtr(), url, delegate);

}

} // namespace policy