Handle additional feedback from http://codereview.chromium.org/8395038/.

chrome/browser/sync/glue/http_bridge_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/message_loop_proxy.h"
 #include "base/threading/thread.h"
 #include "chrome/browser/sync/glue/http_bridge.h"
 #include "chrome/test/base/test_url_request_context_getter.h"
 #include "content/browser/browser_thread.h"
 #include "content/test/test_url_fetcher_factory.h"
@@ skipping 70 matching lines @@
  private:
   // A make-believe "default" request context, as would be returned by
   // Profile::GetDefaultRequestContext().  Created lazily by BuildBridge.
   TestURLRequestContextGetter* fake_default_request_context_getter_;
 
   // Separate thread for IO used by the HttpBridge.
   BrowserThread io_thread_;
   MessageLoop loop_;
 };
 
-class DummyURLFetcher : public TestURLFetcher {
- public:
-  DummyURLFetcher() : TestURLFetcher(0, GURL(), POST, NULL) {}
-
-  net::HttpResponseHeaders* GetResponseHeaders() const {
-    return NULL;
-  }
-};
-
 // An HttpBridge that doesn't actually make network requests and just calls
 // back with dummy response info.
 class ShuntedHttpBridge : public HttpBridge {
  public:
   // If |never_finishes| is true, the simulated request never actually
   // returns.
   ShuntedHttpBridge(net::URLRequestContextGetter* baseline_context_getter,
                     HttpBridgeTest* test, bool never_finishes)
       : HttpBridge(new HttpBridge::RequestContextGetter(
                        baseline_context_getter)),
@@ skipping 11 matching lines @@
   }
  private:
   ~ShuntedHttpBridge() {}
 
   void CallOnURLFetchComplete() {
     ASSERT_TRUE(MessageLoop::current() == test_->io_thread_loop());
     // We return no cookies and a dummy content response.
     net::ResponseCookies cookies;
 
     std::string response_content = "success!";
-    DummyURLFetcher fetcher;
+    TestURLFetcher fetcher(0, GURL(), NULL);
     fetcher.set_url(GURL("www.google.com"));
     fetcher.set_response_code(200);
     fetcher.set_cookies(cookies);
     fetcher.SetResponseString(response_content);
     OnURLFetchComplete(&fetcher);
   }
   HttpBridgeTest* test_;
   bool never_finishes_;
 };
 
@@ skipping 161 matching lines @@
   http_bridge->SetPostPayload("text/plain", 2, " ");
 
   int os_error = 0;
   int response_code = 0;
 
   bool success = http_bridge->MakeSynchronousPost(&os_error, &response_code);
   ASSERT_TRUE(success);
   http_bridge->Abort();
   // Ensures no double-free of URLFetcher, etc.
 }