Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Side by Side Diff: content/browser/speech/speech_recognition_request_unittest.cc

Issue 8416020: Handle additional feedback from http://codereview.chromium.org/8395038/. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/message_loop.h" 5 #include "base/message_loop.h"
6 #include "base/utf_string_conversions.h" 6 #include "base/utf_string_conversions.h"
7 #include "content/browser/speech/speech_recognition_request.h" 7 #include "content/browser/speech/speech_recognition_request.h"
8 #include "content/test/test_url_fetcher_factory.h" 8 #include "content/test/test_url_fetcher_factory.h"
9 #include "net/url_request/url_request_context_getter.h" 9 #include "net/url_request/url_request_context_getter.h"
10 #include "net/url_request/url_request_status.h" 10 #include "net/url_request/url_request_status.h"
(...skipping 23 matching lines...) Expand all
34 34
35 void SpeechRecognitionRequestTest::CreateAndTestRequest( 35 void SpeechRecognitionRequestTest::CreateAndTestRequest(
36 bool success, const std::string& http_response) { 36 bool success, const std::string& http_response) {
37 SpeechRecognitionRequest request(NULL, this); 37 SpeechRecognitionRequest request(NULL, this);
38 request.Start(std::string(), std::string(), false, std::string(), 38 request.Start(std::string(), std::string(), false, std::string(),
39 std::string(), std::string()); 39 std::string(), std::string());
40 request.UploadAudioChunk(std::string(" "), true); 40 request.UploadAudioChunk(std::string(" "), true);
41 TestURLFetcher* fetcher = url_fetcher_factory_.GetFetcherByID(0); 41 TestURLFetcher* fetcher = url_fetcher_factory_.GetFetcherByID(0);
42 ASSERT_TRUE(fetcher); 42 ASSERT_TRUE(fetcher);
43 43
44 fetcher->set_url(fetcher->GetOriginalUrl()); 44 fetcher->set_url(fetcher->GetOriginalURL());
45 net::URLRequestStatus status; 45 net::URLRequestStatus status;
46 status.set_status(success ? net::URLRequestStatus::SUCCESS : 46 status.set_status(success ? net::URLRequestStatus::SUCCESS :
47 net::URLRequestStatus::FAILED); 47 net::URLRequestStatus::FAILED);
48 fetcher->set_status(status); 48 fetcher->set_status(status);
49 fetcher->set_response_code(success ? 200 : 500); 49 fetcher->set_response_code(success ? 200 : 500);
50 fetcher->SetResponseString(http_response); 50 fetcher->SetResponseString(http_response);
51 51
52 fetcher->delegate()->OnURLFetchComplete(fetcher); 52 fetcher->delegate()->OnURLFetchComplete(fetcher);
53 // Parsed response will be available in result_. 53 // Parsed response will be available in result_.
54 } 54 }
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 EXPECT_EQ(0U, result_.hypotheses.size()); 96 EXPECT_EQ(0U, result_.hypotheses.size());
97 97
98 // Malformed JSON case. 98 // Malformed JSON case.
99 CreateAndTestRequest(true, "{\"status\":0,\"hypotheses\":" 99 CreateAndTestRequest(true, "{\"status\":0,\"hypotheses\":"
100 "[{\"unknownkey\":\"hello\"}]}"); 100 "[{\"unknownkey\":\"hello\"}]}");
101 EXPECT_EQ(result_.error, kErrorNetwork); 101 EXPECT_EQ(result_.error, kErrorNetwork);
102 EXPECT_EQ(0U, result_.hypotheses.size()); 102 EXPECT_EQ(0U, result_.hypotheses.size());
103 } 103 }
104 104
105 } // namespace speech_input 105 } // namespace speech_input
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698