Issue 8275035: Fix evaluation order of GT and LTE operators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8275035: Fix evaluation order of GT and LTE operators. (Closed)

Created:
9 years, 2 months ago by Michael Starzinger

Modified:
9 years, 2 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix evaluation order of GT and LTE operators. According to the ES5 spec all ">" and "<=" expressions should be be evaluated left-to-right. This obsoletes old hacks for reversing the order to be ES3 compliant. R=lrn@chromium.org BUG=v8:1752 Commited: http://code.google.com/p/v8/source/detail?r=9641

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -89 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	1 chunk	+3 lines, -11 lines	0 comments	Download
M	src/arm/ic-arm.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/arm/lithium-arm.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	1 chunk	+3 lines, -11 lines	0 comments	Download
M	src/ia32/ic-ia32.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	1 chunk	+3 lines, -11 lines	0 comments	Download
M	src/x64/ic-x64.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	test/mjsunit/compiler/compare.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/mjsunit/to_number_order.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/mozilla/mozilla.status	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	test/sputnik/sputnik.status	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	test/test262/test262.status	View	1 chunk	+0 lines, -13 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages