Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Side by Side Diff: src/ia32/ic-ia32.cc

Issue 8275035: Fix evaluation order of GT and LTE operators. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1573 matching lines...) Expand 10 before | Expand all | Expand 10 after
1584 1584
1585 1585
1586 Condition CompareIC::ComputeCondition(Token::Value op) { 1586 Condition CompareIC::ComputeCondition(Token::Value op) {
1587 switch (op) { 1587 switch (op) {
1588 case Token::EQ_STRICT: 1588 case Token::EQ_STRICT:
1589 case Token::EQ: 1589 case Token::EQ:
1590 return equal; 1590 return equal;
1591 case Token::LT: 1591 case Token::LT:
1592 return less; 1592 return less;
1593 case Token::GT: 1593 case Token::GT:
1594 // Reverse left and right operands to obtain ECMA-262 conversion order. 1594 return greater;
1595 return less;
1596 case Token::LTE: 1595 case Token::LTE:
1597 // Reverse left and right operands to obtain ECMA-262 conversion order. 1596 return less_equal;
1598 return greater_equal;
1599 case Token::GTE: 1597 case Token::GTE:
1600 return greater_equal; 1598 return greater_equal;
1601 default: 1599 default:
1602 UNREACHABLE(); 1600 UNREACHABLE();
1603 return no_condition; 1601 return no_condition;
1604 } 1602 }
1605 } 1603 }
1606 1604
1607 1605
1608 static bool HasInlinedSmiCode(Address address) { 1606 static bool HasInlinedSmiCode(Address address) {
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
1676 Condition cc = *jmp_address == Assembler::kJncShortOpcode 1674 Condition cc = *jmp_address == Assembler::kJncShortOpcode
1677 ? not_zero 1675 ? not_zero
1678 : zero; 1676 : zero;
1679 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc); 1677 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc);
1680 } 1678 }
1681 1679
1682 1680
1683 } } // namespace v8::internal 1681 } } // namespace v8::internal
1684 1682
1685 #endif // V8_TARGET_ARCH_IA32 1683 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698