Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1240)

Side by Side Diff: src/x64/ic-x64.cc

Issue 8275035: Fix evaluation order of GT and LTE operators. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1595 matching lines...) Expand 10 before | Expand all | Expand 10 after
1606 1606
1607 1607
1608 Condition CompareIC::ComputeCondition(Token::Value op) { 1608 Condition CompareIC::ComputeCondition(Token::Value op) {
1609 switch (op) { 1609 switch (op) {
1610 case Token::EQ_STRICT: 1610 case Token::EQ_STRICT:
1611 case Token::EQ: 1611 case Token::EQ:
1612 return equal; 1612 return equal;
1613 case Token::LT: 1613 case Token::LT:
1614 return less; 1614 return less;
1615 case Token::GT: 1615 case Token::GT:
1616 // Reverse left and right operands to obtain ECMA-262 conversion order. 1616 return greater;
1617 return less;
1618 case Token::LTE: 1617 case Token::LTE:
1619 // Reverse left and right operands to obtain ECMA-262 conversion order. 1618 return less_equal;
1620 return greater_equal;
1621 case Token::GTE: 1619 case Token::GTE:
1622 return greater_equal; 1620 return greater_equal;
1623 default: 1621 default:
1624 UNREACHABLE(); 1622 UNREACHABLE();
1625 return no_condition; 1623 return no_condition;
1626 } 1624 }
1627 } 1625 }
1628 1626
1629 1627
1630 static bool HasInlinedSmiCode(Address address) { 1628 static bool HasInlinedSmiCode(Address address) {
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
1697 Condition cc = *jmp_address == Assembler::kJncShortOpcode 1695 Condition cc = *jmp_address == Assembler::kJncShortOpcode
1698 ? not_zero 1696 ? not_zero
1699 : zero; 1697 : zero;
1700 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc); 1698 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc);
1701 } 1699 }
1702 1700
1703 1701
1704 } } // namespace v8::internal 1702 } } // namespace v8::internal
1705 1703
1706 #endif // V8_TARGET_ARCH_X64 1704 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698