Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: src/arm/ic-arm.cc

Issue 8275035: Fix evaluation order of GT and LTE operators. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/arm/lithium-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1541 matching lines...) Expand 10 before | Expand all | Expand 10 after
1552 1552
1553 1553
1554 Condition CompareIC::ComputeCondition(Token::Value op) { 1554 Condition CompareIC::ComputeCondition(Token::Value op) {
1555 switch (op) { 1555 switch (op) {
1556 case Token::EQ_STRICT: 1556 case Token::EQ_STRICT:
1557 case Token::EQ: 1557 case Token::EQ:
1558 return eq; 1558 return eq;
1559 case Token::LT: 1559 case Token::LT:
1560 return lt; 1560 return lt;
1561 case Token::GT: 1561 case Token::GT:
1562 // Reverse left and right operands to obtain ECMA-262 conversion order. 1562 return gt;
1563 return lt;
1564 case Token::LTE: 1563 case Token::LTE:
1565 // Reverse left and right operands to obtain ECMA-262 conversion order. 1564 return le;
1566 return ge;
1567 case Token::GTE: 1565 case Token::GTE:
1568 return ge; 1566 return ge;
1569 default: 1567 default:
1570 UNREACHABLE(); 1568 UNREACHABLE();
1571 return kNoCondition; 1569 return kNoCondition;
1572 } 1570 }
1573 } 1571 }
1574 1572
1575 1573
1576 void CompareIC::UpdateCaches(Handle<Object> x, Handle<Object> y) { 1574 void CompareIC::UpdateCaches(Handle<Object> x, Handle<Object> y) {
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
1666 Register reg = Assembler::GetRn(instr_at_patch); 1664 Register reg = Assembler::GetRn(instr_at_patch);
1667 patcher.masm()->tst(reg, Operand(kSmiTagMask)); 1665 patcher.masm()->tst(reg, Operand(kSmiTagMask));
1668 patcher.EmitCondition(eq); 1666 patcher.EmitCondition(eq);
1669 } 1667 }
1670 } 1668 }
1671 1669
1672 1670
1673 } } // namespace v8::internal 1671 } } // namespace v8::internal
1674 1672
1675 #endif // V8_TARGET_ARCH_ARM 1673 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/arm/lithium-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698