src/arm/lithium-codegen-arm.cc - Issue 8275035: Fix evaluation order of GT and LTE operators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/lithium-codegen-arm.cc

Issue 8275035: Fix evaluation order of GT and LTE operators. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/lithium-codegen-arm.cc

diff --git a/src/arm/lithium-codegen-arm.cc b/src/arm/lithium-codegen-arm.cc

index 460573559c4c460e35356a2f2fab1ba62aea37e6..42d1ec955d7b00a96e212c0de78a311ecf45f08a 100644

--- a/src/arm/lithium-codegen-arm.cc

+++ b/src/arm/lithium-codegen-arm.cc

@@ -2176,9 +2176,6 @@ void LCodeGen::DoCmpT(LCmpT* instr) {

__ cmp(r0, Operand(0)); // This instruction also signals no smi code inlined.

Condition condition = ComputeCompareCondition(op);

- if (op == Token::GT || op == Token::LTE) {

- condition = ReverseCondition(condition);

- }

__ LoadRoot(ToRegister(instr->result()),

Heap::kTrueValueRootIndex,

condition);

« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »