Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 8275035: Fix evaluation order of GT and LTE operators. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/ic-arm.cc ('k') | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1386 matching lines...) Expand 10 before | Expand all | Expand 10 after
1397 UseFixedDouble(instr->right(), d2) : 1397 UseFixedDouble(instr->right(), d2) :
1398 UseFixed(instr->right(), r0); 1398 UseFixed(instr->right(), r0);
1399 LPower* result = new LPower(left, right); 1399 LPower* result = new LPower(left, right);
1400 return MarkAsCall(DefineFixedDouble(result, d3), 1400 return MarkAsCall(DefineFixedDouble(result, d3),
1401 instr, 1401 instr,
1402 CAN_DEOPTIMIZE_EAGERLY); 1402 CAN_DEOPTIMIZE_EAGERLY);
1403 } 1403 }
1404 1404
1405 1405
1406 LInstruction* LChunkBuilder::DoCompareGeneric(HCompareGeneric* instr) { 1406 LInstruction* LChunkBuilder::DoCompareGeneric(HCompareGeneric* instr) {
1407 Token::Value op = instr->token();
1408 ASSERT(instr->left()->representation().IsTagged()); 1407 ASSERT(instr->left()->representation().IsTagged());
1409 ASSERT(instr->right()->representation().IsTagged()); 1408 ASSERT(instr->right()->representation().IsTagged());
1410 bool reversed = (op == Token::GT || op == Token::LTE); 1409 LOperand* left = UseFixed(instr->left(), r1);
1411 LOperand* left = UseFixed(instr->left(), reversed ? r0 : r1); 1410 LOperand* right = UseFixed(instr->right(), r0);
1412 LOperand* right = UseFixed(instr->right(), reversed ? r1 : r0);
1413 LCmpT* result = new LCmpT(left, right); 1411 LCmpT* result = new LCmpT(left, right);
1414 return MarkAsCall(DefineFixed(result, r0), instr); 1412 return MarkAsCall(DefineFixed(result, r0), instr);
1415 } 1413 }
1416 1414
1417 1415
1418 LInstruction* LChunkBuilder::DoCompareIDAndBranch( 1416 LInstruction* LChunkBuilder::DoCompareIDAndBranch(
1419 HCompareIDAndBranch* instr) { 1417 HCompareIDAndBranch* instr) {
1420 Representation r = instr->GetInputRepresentation(); 1418 Representation r = instr->GetInputRepresentation();
1421 if (r.IsInteger32()) { 1419 if (r.IsInteger32()) {
1422 ASSERT(instr->left()->representation().IsInteger32()); 1420 ASSERT(instr->left()->representation().IsInteger32());
(...skipping 761 matching lines...) Expand 10 before | Expand all | Expand 10 after
2184 2182
2185 LInstruction* LChunkBuilder::DoIn(HIn* instr) { 2183 LInstruction* LChunkBuilder::DoIn(HIn* instr) {
2186 LOperand* key = UseRegisterAtStart(instr->key()); 2184 LOperand* key = UseRegisterAtStart(instr->key());
2187 LOperand* object = UseRegisterAtStart(instr->object()); 2185 LOperand* object = UseRegisterAtStart(instr->object());
2188 LIn* result = new LIn(key, object); 2186 LIn* result = new LIn(key, object);
2189 return MarkAsCall(DefineFixed(result, r0), instr); 2187 return MarkAsCall(DefineFixed(result, r0), instr);
2190 } 2188 }
2191 2189
2192 2190
2193 } } // namespace v8::internal 2191 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/ic-arm.cc ('k') | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698