Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 7739002: Revert 98850 - Proper MouseEvent targeting. Adds a Window method that locates a Window for a give... (Closed)

Created:
9 years, 3 months ago by jar (doing other things)
Modified:
9 years, 3 months ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 98850 - Proper MouseEvent targeting. Adds a Window method that locates a Window for a given point. Also adds an Aura test suite. http://crbug.com/93933 http://crbug.com/93943 TEST=see unittest Review URL: http://codereview.chromium.org/7791030 TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98852

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -405 lines) Patch
M aura/aura.gyp View 2 chunks +0 lines, -26 lines 0 comments Download
M aura/demo/demo_main.cc View 3 chunks +1 line, -5 lines 0 comments Download
M aura/desktop.h View 4 chunks +3 lines, -8 lines 0 comments Download
M aura/desktop.cc View 2 chunks +4 lines, -12 lines 0 comments Download
M aura/desktop_host.h View 1 chunk +1 line, -2 lines 0 comments Download
M aura/desktop_host_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M aura/desktop_host_win.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M aura/event.h View 3 chunks +0 lines, -12 lines 0 comments Download
M aura/event.cc View 2 chunks +0 lines, -15 lines 0 comments Download
D aura/root_window.h View 1 chunk +0 lines, -33 lines 0 comments Download
D aura/root_window.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D aura/run_all_unittests.cc View 1 chunk +0 lines, -9 lines 0 comments Download
D aura/test_suite.h View 1 chunk +0 lines, -22 lines 0 comments Download
D aura/test_suite.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M aura/window.h View 2 chunks +0 lines, -18 lines 0 comments Download
M aura/window.cc View 3 chunks +1 line, -31 lines 0 comments Download
M aura/window_delegate.h View 1 chunk +1 line, -9 lines 0 comments Download
D aura/window_unittest.cc View 1 chunk +0 lines, -124 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jar (doing other things)
9 years, 3 months ago (2011-08-30 18:52:35 UTC) #1
Ben Goodger (Google)
9 years, 3 months ago (2011-08-30 19:00:35 UTC) #2
LGTM thanks

On Tue, Aug 30, 2011 at 11:52 AM, <jar@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> Revert 98850 - Proper MouseEvent targeting. Adds a Window method that
> locates a
> Window for a given point.
>
> Also adds an Aura test suite.
>
> http://crbug.com/93933
> http://crbug.com/93943
> TEST=see unittest
> Review URL:
http://codereview.chromium.**org/7791030<http://codereview.chromium.org/7791030>
>
> TBR=ben@chromium.org
>
> Please review this at
http://codereview.chromium.**org/7739002/<http://codereview.chromium.org/7739...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>  M     aura/aura.gyp
>  M     aura/demo/demo_main.cc
>  M     aura/desktop.h
>  M     aura/desktop.cc
>  M     aura/desktop_host.h
>  M     aura/desktop_host_win.h
>  M     aura/desktop_host_win.cc
>  M     aura/event.h
>  M     aura/event.cc
>  D     aura/root_window.h
>  D     aura/root_window.cc
>  D     aura/run_all_unittests.cc
>  D     aura/test_suite.h
>  D     aura/test_suite.cc
>  M     aura/window.h
>  M     aura/window.cc
>  M     aura/window_delegate.h
>  D     aura/window_unittest.cc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698