Issue 7791030: Proper MouseEvent targeting. Adds a Window method that locates a Window for a given point.

Issue 7791030: Proper MouseEvent targeting. Adds a Window method that locates a Window for a given point. (Closed)

Created:
9 years, 3 months ago by Ben Goodger (Google)

Modified:
9 years, 3 months ago

Reviewers:
sky

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Proper MouseEvent targeting. Adds a Window method that locates a Window for a given point. Also adds an Aura test suite. http://crbug.com/93933 http://crbug.com/93943 TEST=see unittest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98850 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98866

Patch Set 5 : '' #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+147 lines, -5 lines)			Patch
M	aura/aura.gyp	View	1 2 3 4	2 chunks	+26 lines, -0 lines	0 comments	Download
M	aura/demo/demo_main.cc	View	1 2 3 4	3 chunks	+8 lines, -1 line	0 comments	Download
M	aura/desktop.h	View	1 2 3 4	4 chunks	+8 lines, -3 lines	0 comments	Download
M	aura/desktop.cc	View	1 2 3 4	2 chunks	+12 lines, -4 lines	0 comments	Download
M	aura/desktop_host.h	View	1 2 3 4	1 chunk	+2 lines, -1 line	0 comments	Download
M	aura/desktop_host_win.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	aura/desktop_host_win.cc	View	1 2 3 4	1 chunk	+11 lines, -0 lines	0 comments	Download
M	aura/event.h	View	1 2 3 4	3 chunks	+12 lines, -0 lines	0 comments	Download
M	aura/event.cc	View	1 2 3 4	2 chunks	+15 lines, -0 lines	0 comments	Download
A +	aura/root_window.h	View	1 2 3 4	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	aura/root_window.cc	View	1 2 3 4	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	aura/run_all_unittests.cc	View	1 2 3 4	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	aura/test_suite.h	View	1 2 3 4	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	aura/test_suite.cc	View	1 2 3 4	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	aura/window.h	View	1 2 3 4	2 chunks	+18 lines, -0 lines	0 comments	Download
M	aura/window.cc	View	1 2 3 4	3 chunks	+31 lines, -1 line	0 comments	Download
M	aura/window_delegate.h	View	1 2 3 4	1 chunk	+9 lines, -1 line	0 comments	Download
A +	aura/window_unittest.cc	View	1 2 3 4	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM http://codereview.chromium.org/7791030/diff/7001/aura/window_unittest.cc File aura/window_unittest.cc (right): http://codereview.chromium.org/7791030/diff/7001/aura/window_unittest.cc#newcode77 aura/window_unittest.cc:77: } nit: // namespace

9 years, 3 months ago (2011-08-30 17:54:12 UTC) #2

sky

9 years, 3 months ago (2011-08-30 18:26:30 UTC) #4

SLGTM

http://codereview.chromium.org/7791030/diff/4003/aura/root_window.h
File aura/root_window.h (right):

http://codereview.chromium.org/7791030/diff/4003/aura/root_window.h#newcode14
aura/root_window.h:14: class RootWindow : public Window {
nit: add a description?

Expand Messages | Collapse Messages