Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 7659015: Revert 96982 - Add gl.dll, compositor.dll, and surface.dll. (Closed)

Created:
9 years, 4 months ago by rvargas (doing something else)
Modified:
9 years, 4 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing)
Visibility:
Public.

Description

Revert 96982 - Add gl.dll, compositor.dll, and surface.dll. I considered merging these into ui.dll, but the respective GYP files are pretty customized, and merging all of the special casing into ui.gyp seemed like it would just make things messy. Plus, some components only need to link to surface and not all of ui. One thing that I'm not entirely sure about is the naming convention. In this case the modules are named gl, compositor and surface instead of ui_gfx_gl, and so on. I thought about declaring UI_GFX_GL_EXPORT, but I opted for the shorter GL_EXPORT instead. I think Ben has been thinking about moving these directories out of ui/gfx/ anyways since it is a bit odd for them to live there. R=rvargas Review URL: http://codereview.chromium.org/7645004 TBR=darin@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96997

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -146 lines) Patch
M chrome/chrome_dll.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M media/video/picture.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/compositor/compositor.h View 3 chunks +2 lines, -3 lines 0 comments Download
M ui/gfx/compositor/compositor.gyp View 1 chunk +1 line, -5 lines 0 comments Download
D ui/gfx/compositor/compositor_export.h View 1 chunk +0 lines, -26 lines 0 comments Download
M ui/gfx/compositor/compositor_gl.h View 2 chunks +2 lines, -2 lines 0 comments Download
ui/gfx/compositor/layer.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/compositor/layer_animator.h View 2 chunks +1 line, -2 lines 0 comments Download
M ui/gfx/gl/generate_bindings.py View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/gl/gl.gyp View 3 chunks +1 line, -5 lines 0 comments Download
M ui/gfx/gl/gl_bindings.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/gl/gl_bindings_skia_in_process.h View 1 chunk +1 line, -3 lines 0 comments Download
M ui/gfx/gl/gl_context.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/gl/gl_context_stub.h View 1 chunk +1 line, -1 line 0 comments Download
D ui/gfx/gl/gl_export.h View 1 chunk +0 lines, -26 lines 0 comments Download
M ui/gfx/gl/gl_implementation.h View 3 chunks +2 lines, -3 lines 0 comments Download
M ui/gfx/gl/gl_interface.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/gl/gl_share_group.h View 1 chunk +1 line, -2 lines 0 comments Download
M ui/gfx/gl/gl_surface.h View 2 chunks +1 line, -2 lines 0 comments Download
M ui/gfx/gl/gl_surface_egl.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/gl/gl_surface_glx.h View 1 chunk +1 line, -2 lines 0 comments Download
M ui/gfx/gl/gl_surface_stub.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/gl/gl_switches.h View 1 chunk +8 lines, -10 lines 0 comments Download
M ui/gfx/surface/accelerated_surface_linux.h View 1 chunk +1 line, -3 lines 0 comments Download
M ui/gfx/surface/accelerated_surface_mac.h View 2 chunks +1 line, -2 lines 0 comments Download
M ui/gfx/surface/accelerated_surface_wayland.h View 1 chunk +1 line, -3 lines 0 comments Download
ui/gfx/surface/io_surface_support_mac.h View 3 chunks +2 lines, -3 lines 0 comments Download
M ui/gfx/surface/surface.gyp View 2 chunks +1 line, -5 lines 0 comments Download
D ui/gfx/surface/surface_export.h View 1 chunk +0 lines, -26 lines 0 comments Download
M ui/gfx/surface/transport_dib.h View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
rvargas (doing something else)
9 years, 4 months ago (2011-08-16 18:54:10 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698