Add gl.dll, compositor.dll, and surface.dll.

Add gl.dll, compositor.dll, and surface.dll.

I considered merging these into ui.dll, but the respective GYP files are pretty
customized, and merging all of the special casing into ui.gyp seemed like it
would just make things messy.  Plus, some components only need to link to
surface and not all of ui.

One thing that I'm not entirely sure about is the naming convention.  In this
case the modules are named gl, compositor and surface instead of ui_gfx_gl, and
so on.  I thought about declaring UI_GFX_GL_EXPORT, but I opted for the shorter
GL_EXPORT instead.  I think Ben has been thinking about moving these
directories out of ui/gfx/ anyways since it is a bit odd for them to live there.

R=rvargas
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96982

[darin (slow to review), 2011-08-12 21:46:57]

I was motivated to make this change based on an exchange with backer yesterday
on #chromium.  He said he was running into some problems caused by the gl
library code being replicated in multiple DLLs.  Apparently, there are some
singletons that do not like that.

[rvargas (doing something else), 2011-08-12 23:07:52]

Maybe we can fold composer into UI and leave gl and surface as dlls?

I'm happy with the names of the export macros, but we could force gl to have a
longer name in the generated file... there may be some gllib.so already
somewhere. We use crnss.dll (for instance)

http://codereview.chromium.org/7645004/diff/1/ui/gfx/compositor/compositor_ex...
File ui/gfx/compositor/compositor_export.h (right):

http://codereview.chromium.org/7645004/diff/1/ui/gfx/compositor/compositor_ex...
ui/gfx/compositor/compositor_export.h:16: #endif  // defined(UI_IMPLEMENTATION)
COMPOSITOR_IMPL

http://codereview.chromium.org/7645004/diff/1/ui/gfx/gl/gl_bindings.h
File ui/gfx/gl/gl_bindings.h (right):

http://codereview.chromium.org/7645004/diff/1/ui/gfx/gl/gl_bindings.h#newcode19
ui/gfx/gl/gl_bindings.h:19: #include "ui/gfx/gl/gl_export.h"
Why is this needed here?

http://codereview.chromium.org/7645004/diff/1/ui/gfx/gl/gl_export.h
File ui/gfx/gl/gl_export.h (right):

http://codereview.chromium.org/7645004/diff/1/ui/gfx/gl/gl_export.h#newcode16
ui/gfx/gl/gl_export.h:16: #endif  // defined(UI_IMPLEMENTATION)
GL_IMPL

http://codereview.chromium.org/7645004/diff/1/ui/gfx/surface/surface_export.h
File ui/gfx/surface/surface_export.h (right):

http://codereview.chromium.org/7645004/diff/1/ui/gfx/surface/surface_export.h...
ui/gfx/surface/surface_export.h:16: #endif  // defined(UI_IMPLEMENTATION)
SURFACE_IMPL

[darin (slow to review), 2011-08-12 23:11:20]

On Fri, Aug 12, 2011 at 4:07 PM, <rvargas@chromium.org> wrote:

> Maybe we can fold composer into UI and leave gl and surface as dlls?
>

compositor depends on gl, and gl depends on ui.  compositor also depends on
ui.  folding compositor into ui, implies folding gl into ui.



>
> I'm happy with the names of the export macros, but we could force gl to
> have a
> longer name in the generated file... there may be some gllib.so already
> somewhere. We use crnss.dll (for instance)
>

I see.  maybe we can worry about this if it becomes a problem?


>
>
> http://codereview.chromium.**org/7645004/diff/1/ui/gfx/**
>
compositor/compositor_export.h<http://codereview.chromium.org/7645004/diff/1/ui/gfx/compositor/compositor_export.h>
> File ui/gfx/compositor/compositor_**export.h (right):
>
> http://codereview.chromium.**org/7645004/diff/1/ui/gfx/**
>
compositor/compositor_export.**h#newcode16<http://codereview.chromium.org/7645004/diff/1/ui/gfx/compositor/compositor_export.h#newcode16>
> ui/gfx/compositor/compositor_**export.h:16: #endif  //
> defined(UI_IMPLEMENTATION)
> COMPOSITOR_IMPL
>

thanks


>
>
http://codereview.chromium.**org/7645004/diff/1/ui/gfx/gl/**gl_bindings.h<htt...
> File ui/gfx/gl/gl_bindings.h (right):
>
> http://codereview.chromium.**org/7645004/diff/1/ui/gfx/gl/**
>
gl_bindings.h#newcode19<http://codereview.chromium.org/7645004/diff/1/ui/gfx/gl/gl_bindings.h#newcode19>
> ui/gfx/gl/gl_bindings.h:19: #include "ui/gfx/gl/gl_export.h"
> Why is this needed here?
>

it is referenced in the generated bindings, which are included later on in
gl_bindings.h.


>
>
http://codereview.chromium.**org/7645004/diff/1/ui/gfx/gl/**gl_export.h<http:...
> File ui/gfx/gl/gl_export.h (right):
>
> http://codereview.chromium.**org/7645004/diff/1/ui/gfx/gl/**
>
gl_export.h#newcode16<http://codereview.chromium.org/7645004/diff/1/ui/gfx/gl/gl_export.h#newcode16>
> ui/gfx/gl/gl_export.h:16: #endif  // defined(UI_IMPLEMENTATION)
> GL_IMPL
>

thanks


>
> http://codereview.chromium.**org/7645004/diff/1/ui/gfx/**
>
surface/surface_export.h<http://codereview.chromium.org/7645004/diff/1/ui/gfx/surface/surface_export.h>
> File ui/gfx/surface/surface_export.**h (right):
>
> http://codereview.chromium.**org/7645004/diff/1/ui/gfx/**
>
surface/surface_export.h#**newcode16<http://codereview.chromium.org/7645004/diff/1/ui/gfx/surface/surface_export.h#newcode16>
> ui/gfx/surface/surface_export.**h:16: #endif  //
> defined(UI_IMPLEMENTATION)
> SURFACE_IMPL
>
>
thanks


>
>
http://codereview.chromium.**org/7645004/<http://codereview.chromium.org/7645...
>

[rvargas (doing something else), 2011-08-12 23:33:16]

On 2011/08/12 23:11:20, darin wrote:
> On Fri, Aug 12, 2011 at 4:07 PM, <mailto:rvargas@chromium.org> wrote:
> 
> > Maybe we can fold composer into UI and leave gl and surface as dlls?
> >
> 
> compositor depends on gl, and gl depends on ui.  compositor also depends on
> ui.  folding compositor into ui, implies folding gl into ui.

I see. It looks a good example of the proliferation of tiny static libs that
could be merged with something else (GL?), but I see the point of not doing
that.

LGTM


> 
> 
> 
> >
> > I'm happy with the names of the export macros, but we could force gl to
> > have a
> > longer name in the generated file... there may be some gllib.so already
> > somewhere. We use crnss.dll (for instance)
> >
> 
> I see.  maybe we can worry about this if it becomes a problem?
> 
> 
> >
> >
> > http://codereview.chromium.**org/7645004/diff/1/ui/gfx/**
> >
>
compositor/compositor_export.h<http://codereview.chromium.org/7645004/diff/1/ui/gfx/compositor/compositor_export.h>
> > File ui/gfx/compositor/compositor_**export.h (right):
> >
> > http://codereview.chromium.**org/7645004/diff/1/ui/gfx/**
> >
>
compositor/compositor_export.**h#newcode16<http://codereview.chromium.org/7645004/diff/1/ui/gfx/compositor/compositor_export.h#newcode16>
> > ui/gfx/compositor/compositor_**export.h:16: #endif  //
> > defined(UI_IMPLEMENTATION)
> > COMPOSITOR_IMPL
> >
> 
> thanks
> 
> 
> >
> >
>
http://codereview.chromium.**org/7645004/diff/1/ui/gfx/gl/**gl_bindings.h%3Ch...>
> > File ui/gfx/gl/gl_bindings.h (right):
> >
> > http://codereview.chromium.**org/7645004/diff/1/ui/gfx/gl/**
> >
>
gl_bindings.h#newcode19<http://codereview.chromium.org/7645004/diff/1/ui/gfx/gl/gl_bindings.h#newcode19>
> > ui/gfx/gl/gl_bindings.h:19: #include "ui/gfx/gl/gl_export.h"
> > Why is this needed here?
> >
> 
> it is referenced in the generated bindings, which are included later on in
> gl_bindings.h.
> 
> 
> >
> >
>
http://codereview.chromium.**org/7645004/diff/1/ui/gfx/gl/**gl_export.h%3Chtt...>
> > File ui/gfx/gl/gl_export.h (right):
> >
> > http://codereview.chromium.**org/7645004/diff/1/ui/gfx/gl/**
> >
>
gl_export.h#newcode16<http://codereview.chromium.org/7645004/diff/1/ui/gfx/gl/gl_export.h#newcode16>
> > ui/gfx/gl/gl_export.h:16: #endif  // defined(UI_IMPLEMENTATION)
> > GL_IMPL
> >
> 
> thanks
> 
> 
> >
> > http://codereview.chromium.**org/7645004/diff/1/ui/gfx/**
> >
>
surface/surface_export.h<http://codereview.chromium.org/7645004/diff/1/ui/gfx/surface/surface_export.h>
> > File ui/gfx/surface/surface_export.**h (right):
> >
> > http://codereview.chromium.**org/7645004/diff/1/ui/gfx/**
> >
>
surface/surface_export.h#**newcode16<http://codereview.chromium.org/7645004/diff/1/ui/gfx/surface/surface_export.h#newcode16>
> > ui/gfx/surface/surface_export.**h:16: #endif  //
> > defined(UI_IMPLEMENTATION)
> > SURFACE_IMPL
> >
> >
> thanks
> 
> 
> >
> >
>
http://codereview.chromium.**org/7645004/%3Chttp://codereview.chromium.org/76...>
> >

[darin (slow to review), 2011-08-12 23:34:48]

Yeah, my original idea was to merge all of this into ui.dll.  I may still go
back and do that...  for now, I'll just go with this.