Issue 7377012: Change base::LaunchProcess API slightly

Issue 7377012: Change base::LaunchProcess API slightly (Closed)

Created:
9 years, 5 months ago by Evan Martin

Modified:
9 years, 5 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, vrk (LEFT CHROMIUM), acolwell+watch_chromium.org, kkania, amit, annacc+watch_chromium.org, ajwong+watch_chromium.org, ncarter (slow), idana, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, tim (not reviewing), derat+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, Raghu Simha, cbentzel+watch_chromium.org, pam+watch_chromium.org, scherkus (not reviewing), hclam+watch_chromium.org, sjl, tfarina, Paweł Hajdan Jr., davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Change base::LaunchProcess API slightly Rather than passing the out param process handle via the options, take it as a function argument. This simplifies many callers. BUG=88990 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92701

Patch Set 1 #

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+89 lines, -134 lines)			Patch
M	base/process_util.h	View	11 chunks	+20 lines, -23 lines	0 comments	Download
M	base/process_util_posix.cc	View	2 chunks	+7 lines, -5 lines	0 comments	Download
M	base/process_util_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/process_util_win.cc	View	3 chunks	+7 lines, -5 lines	0 comments	Download
M	base/test/multiprocess_test.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/browser_main.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/browser_main_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_manager.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/xkeyboard.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/chromeos/system/touchpad_settings.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/first_run/first_run_gtk.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/first_run/first_run_win.cc	View	2 chunks	+3 lines, -6 lines	0 comments	Download
M	chrome/browser/first_run/upgrade_util_linux.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/first_run/upgrade_util_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/importer/firefox_importer_unittest_utils_mac.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/mac/relauncher.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/platform_util_linux.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/printing/printer_manager_dialog_linux.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/process_info_snapshot_mac_unittest.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/process_singleton_uitest.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_test.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/service/service_process_control.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/shell_integration_linux.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/options/advanced_options_utils_gtk.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/common/launchd_mac.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/google_chrome_distribution.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/util/product.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/service/cloud_print/cloud_print_proxy.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/service/service_child_process_host.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/test/automation/proxy_launcher.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/test/layout_test_http_server.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/test/live_sync/live_sync_test.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/test/out_of_proc_test_runner.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/test/ui_test_utils.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome_frame/ready_mode/internal/registry_ready_mode_state.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome_frame/test/chrome_frame_test_utils.cc	View	3 chunks	+5 lines, -12 lines	0 comments	Download
M	content/browser/child_process_launcher.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	content/browser/zygote_host_linux.cc	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	content/common/sandbox_policy.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	media/audio/linux/audio_manager_linux.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	media/audio/win/audio_manager_win.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	net/disk_cache/stress_cache.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	net/test/test_server_posix.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	net/tools/crash_cache/crash_cache.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	net/tools/dump_cache/dump_cache.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

would you believe I got the API right on the first try?

9 years, 5 months ago (2011-07-14 23:56:08 UTC) #1

Evan Martin

9 years, 5 months ago (2011-07-15 16:40:21 UTC) #2

Mark's comments via email, for history:

"LGTM. This is pretty clean.

Rietveld won’t let me make comments directly. Here was my only comment:

process_util.h:366
Heh, oops!"

Expand Messages | Collapse Messages