Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8544)

Unified Diff: chrome/test/out_of_proc_test_runner.cc

Issue 7377012: Change base::LaunchProcess API slightly (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/live_sync/live_sync_test.cc ('k') | chrome/test/ui_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/out_of_proc_test_runner.cc
diff --git a/chrome/test/out_of_proc_test_runner.cc b/chrome/test/out_of_proc_test_runner.cc
index 9b230bac660998fd3567b13b121626ae98716302..94ff0d53b134af84a59a3c4517976471e3327cc7 100644
--- a/chrome/test/out_of_proc_test_runner.cc
+++ b/chrome/test/out_of_proc_test_runner.cc
@@ -354,7 +354,6 @@ int RunTest(const std::string& test_name, int default_timeout_ms) {
base::ProcessHandle process_handle;
base::LaunchOptions options;
- options.process_handle = &process_handle;
#if defined(OS_POSIX)
const char* browser_wrapper = getenv("BROWSER_WRAPPER");
@@ -371,7 +370,7 @@ int RunTest(const std::string& test_name, int default_timeout_ms) {
options.new_process_group = true;
#endif
- if (!base::LaunchProcess(new_cmd_line, options))
+ if (!base::LaunchProcess(new_cmd_line, options, &process_handle))
return false;
int timeout_ms =
« no previous file with comments | « chrome/test/live_sync/live_sync_test.cc ('k') | chrome/test/ui_test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698