Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5122)

Unified Diff: chrome_frame/test/chrome_frame_test_utils.cc

Issue 7377012: Change base::LaunchProcess API slightly (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome_frame/test/chrome_frame_test_utils.cc
diff --git a/chrome_frame/test/chrome_frame_test_utils.cc b/chrome_frame/test/chrome_frame_test_utils.cc
index 397a07be762754a587b0bd9abf235b3a08f89b14..240cec21573785713a7a7f3aaa2931b2219bde52 100644
--- a/chrome_frame/test/chrome_frame_test_utils.cc
+++ b/chrome_frame/test/chrome_frame_test_utils.cc
@@ -159,18 +159,14 @@ base::ProcessHandle LaunchExecutable(const std::wstring& executable,
LOG(ERROR) << "Failed to find executable: " << executable;
} else {
CommandLine cmdline = CommandLine::FromString(path);
- base::LaunchOptions options;
- options.process_handle = &process;
- if (!base::LaunchProcess(cmdline, options)) {
+ if (!base::LaunchProcess(cmdline, base::LaunchOptions(), &process)) {
LOG(ERROR) << "LaunchProcess failed: " << ::GetLastError();
}
}
} else {
CommandLine cmdline((FilePath(path)));
cmdline.AppendArgNative(argument);
- base::LaunchOptions options;
- options.process_handle = &process;
- if (!base::LaunchProcess(cmdline, options)) {
+ if (!base::LaunchProcess(cmdline, base::LaunchOptions(), &process)) {
LOG(ERROR) << "LaunchProcess failed: " << ::GetLastError();
}
}
@@ -187,9 +183,7 @@ base::ProcessHandle LaunchChrome(const std::wstring& url) {
cmd.AppendArgNative(url);
base::ProcessHandle process = NULL;
- base::LaunchOptions options;
- options.process_handle = &process;
- base::LaunchProcess(cmd, options);
+ base::LaunchProcess(cmd, base::LaunchOptions(), &process);
return process;
}
@@ -596,9 +590,8 @@ base::ProcessHandle StartCrashService() {
DVLOG(1) << "Starting crash_service.exe so you know if a test crashes!";
FilePath crash_service_path = exe_dir.AppendASCII("crash_service.exe");
- base::LaunchOptions options;
- options.process_handle = &crash_service;
- if (!base::LaunchProcess(crash_service_path.value(), options)) {
+ if (!base::LaunchProcess(crash_service_path.value(), base::LaunchOptions(),
+ &crash_service)) {
DLOG(ERROR) << "Couldn't start crash_service.exe";
return NULL;
}
« no previous file with comments | « chrome_frame/ready_mode/internal/registry_ready_mode_state.cc ('k') | content/browser/child_process_launcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698