Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: chrome/browser/first_run/first_run_win.cc

Issue 7377012: Change base::LaunchProcess API slightly (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/first_run/first_run_gtk.cc ('k') | chrome/browser/first_run/upgrade_util_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/first_run/first_run_win.cc
diff --git a/chrome/browser/first_run/first_run_win.cc b/chrome/browser/first_run/first_run_win.cc
index 3d0eb3f78fc6ce6e563a7312d79d2818a13da7b8..2a62ad7bd017ce07dead02ac35eacb47ab5362f9 100644
--- a/chrome/browser/first_run/first_run_win.cc
+++ b/chrome/browser/first_run/first_run_win.cc
@@ -145,9 +145,8 @@ bool FirstRun::LaunchSetupWithParam(const std::string& param,
cl.AppendSwitch(switches::kChromeFrame);
}
- base::LaunchOptions options;
- options.process_handle = &ph;
- if (!base::LaunchProcess(cl, options))
+ // TODO(evan): should this use options.wait = true?
+ if (!base::LaunchProcess(cl, base::LaunchOptions(), &ph))
return false;
DWORD wr = ::WaitForSingleObject(ph, INFINITE);
if (wr != WAIT_OBJECT_0)
@@ -344,9 +343,7 @@ bool FirstRun::ImportSettings(Profile* profile,
// Time to launch the process that is going to do the import.
base::ProcessHandle import_process;
- base::LaunchOptions options;
- options.process_handle = &import_process;
- if (!base::LaunchProcess(import_cmd, options))
+ if (!base::LaunchProcess(import_cmd, base::LaunchOptions(), &import_process))
return false;
// We block inside the import_runner ctor, pumping messages until the
« no previous file with comments | « chrome/browser/first_run/first_run_gtk.cc ('k') | chrome/browser/first_run/upgrade_util_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698