Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: base/process_util_posix.cc

Issue 7377012: Change base::LaunchProcess API slightly (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/process_util.h ('k') | base/process_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/process_util_posix.cc
diff --git a/base/process_util_posix.cc b/base/process_util_posix.cc
index 0e116de82671a48bab94f6fa0affcaf8bc9daeff..0fc8c0e1537b7b1797c887d89a891b3698530f94 100644
--- a/base/process_util_posix.cc
+++ b/base/process_util_posix.cc
@@ -528,7 +528,8 @@ char** AlterEnvironment(const environment_vector& changes,
}
bool LaunchProcess(const std::vector<std::string>& argv,
- const LaunchOptions& options) {
+ const LaunchOptions& options,
+ ProcessHandle* process_handle) {
pid_t pid;
InjectiveMultimap fd_shuffle1, fd_shuffle2;
if (options.fds_to_remap) {
@@ -631,16 +632,17 @@ bool LaunchProcess(const std::vector<std::string>& argv,
DPCHECK(ret > 0);
}
- if (options.process_handle)
- *options.process_handle = pid;
+ if (process_handle)
+ *process_handle = pid;
}
return true;
}
bool LaunchProcess(const CommandLine& cmdline,
- const LaunchOptions& options) {
- return LaunchProcess(cmdline.argv(), options);
+ const LaunchOptions& options,
+ ProcessHandle* process_handle) {
+ return LaunchProcess(cmdline.argv(), options, process_handle);
}
ProcessMetrics::~ProcessMetrics() { }
« no previous file with comments | « base/process_util.h ('k') | base/process_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698