Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 7308004: Extract string->double and double->string conversions for use in the preparser. (Closed)

Created:
9 years, 5 months ago by Lasse Reichstein
Modified:
9 years, 5 months ago
Reviewers:
Rico
CC:
v8-dev
Visibility:
Public.

Description

Extract string->double and double->string conversions for use in the preparser. Committed: http://code.google.com/p/v8/source/detail?r=8534

Patch Set 1 #

Total comments: 8

Patch Set 2 : git utd #

Unified diffs Side-by-side diffs Delta from patch set Stats (+899 lines, -1165 lines) Patch
M src/SConscript View 2 chunks +7 lines, -0 lines 0 comments Download
M src/bignum.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/cached-powers.cc View 1 3 chunks +8 lines, -4 lines 0 comments Download
M src/conversions.h View 3 chunks +25 lines, -12 lines 0 comments Download
M src/conversions.cc View 9 chunks +9 lines, -687 lines 0 comments Download
M src/conversions-inl.h View 1 4 chunks +570 lines, -14 lines 0 comments Download
M src/diy-fp.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/diy-fp.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/json-parser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/liveobjectlist.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/preparser.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/strtod.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M src/utils.h View 1 chunk +63 lines, -0 lines 0 comments Download
M src/utils.cc View 1 4 chunks +25 lines, -304 lines 0 comments Download
A + src/v8conversions.h View 2 chunks +26 lines, -24 lines 0 comments Download
A src/v8conversions.cc View 1 1 chunk +129 lines, -0 lines 0 comments Download
M src/v8utils.h View 3 chunks +14 lines, -66 lines 0 comments Download
A + src/v8utils.cc View 3 chunks +1 line, -38 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein
9 years, 5 months ago (2011-07-05 07:14:32 UTC) #1
Rico
LGTM As discussed offline, this is simple moved code except the AddDecimalInteger in utils.cc. http://codereview.chromium.org/7308004/diff/1/src/cached-powers.cc ...
9 years, 5 months ago (2011-07-05 08:54:57 UTC) #2
Lasse Reichstein
9 years, 5 months ago (2011-07-05 10:43:18 UTC) #3
http://codereview.chromium.org/7308004/diff/1/src/conversions-inl.h
File src/conversions-inl.h (right):

http://codereview.chromium.org/7308004/diff/1/src/conversions-inl.h#newcode108
src/conversions-inl.h:108: // Returns true if a nonspace found and false if the
end has reached.
rewritten.

http://codereview.chromium.org/7308004/diff/1/src/utils.cc
File src/utils.cc (right):

http://codereview.chromium.org/7308004/diff/1/src/utils.cc#newcode63
src/utils.cc:63: void SimpleStringBuilder::AddDecimalInteger(int value) {
I'd prefer to take it signed, but I'll make it int32_t to make the size
explicit.

http://codereview.chromium.org/7308004/diff/1/src/v8conversions.cc
File src/v8conversions.cc (right):

http://codereview.chromium.org/7308004/diff/1/src/v8conversions.cc#newcode81
src/v8conversions.cc:81: }
Done.

Powered by Google App Engine
This is Rietveld 408576698