Moved code that runs in both the browser and GPU process from content/gpu to content/common/gpu.

Moved code that runs in both the browser and GPU process from content/gpu to content/common/gpu.

Also renamed GpuRenderThread to GpuChannelManager since that is what it really does.

The only remaining dependency from content/common/gpu to content/gpu is gpu_watchdog_thread.h. Once that dependency has been reversed it should be possible to move most or all of the code in content/gpu to chrome/gpu.

TEST=build, WebGL works, run by trybots.
BUG=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80883

[jam, 2011-04-05 23:37:02]

Is there a specific part you want me to review?  I'm not familiar with the
gpu code.

Why would we want to move the code from content\gpu to chrome\gpu?  I moved
it from chrome to content because this code belongs in content :)

On Tue, Apr 5, 2011 at 4:22 PM, <apatrick@chromium.org> wrote:

> Reviewers: Alexey Marinichev, John Abd-El-Malek,
>
> Description:
> Moved code that runs in both the browser and GPU process from content/gpu
> to
> content/common/gpu.
>
> Also renamed GpuRenderThread to GpuChannelManager since that is what it
> really
> does.
>
> The only remaining dependency from content/common/gpu to content/gpu is
> gpu_watchdog_thread.h. Once that dependency has been reversed it should be
> possible to move most or all of the code in content/gpu to chrome/gpu.
>
> TEST=build, WebGL works, run by trybots.
> BUG=none
>
> Please review this at http://codereview.chromium.org/6793054/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/gpu_data_manager.h
>  M     chrome/browser/gpu_process_host_ui_shim.h
>  M     chrome/browser/gpu_process_host_ui_shim.cc
>  M     chrome/chrome_tests.gypi
>  M     chrome/common/child_process_logging_linux.cc
>  M     chrome/common/child_process_logging_mac.mm
>  M     chrome/common/child_process_logging_win.cc
>  M     chrome/common/chrome_content_gpu_client.h
>  M     chrome/test/gpu/gpu_pixel_browsertest.cc
>  M     content/browser/DEPS
>  M     content/browser/gpu_blacklist.cc
>  M     content/browser/gpu_blacklist_unittest.cc
>  A  +  content/common/gpu/DEPS
>  A  +  content/common/gpu/OWNERS
>  A  +  content/common/gpu/content_gpu_client.h
>  A  +  content/common/gpu/gpu_channel.h
>  A  +  content/common/gpu/gpu_channel.cc
>  A  +  content/common/gpu/gpu_channel_manager.h
>  A  +  content/common/gpu/gpu_channel_manager.cc
>  A  +  content/common/gpu/gpu_command_buffer_stub.h
>  A  +  content/common/gpu/gpu_command_buffer_stub.cc
>  A  +  content/common/gpu/gpu_config.h
>  A  +  content/common/gpu/gpu_info.h
>  A  +  content/common/gpu/gpu_info.cc
>  A  +  content/common/gpu/gpu_info_unittest.cc
>  A  +  content/common/gpu/gpu_video_decoder.h
>  A  +  content/common/gpu/gpu_video_decoder.cc
>  A  +  content/common/gpu/gpu_video_decoder_unittest.cc
>  A  +  content/common/gpu/gpu_video_service.h
>  A  +  content/common/gpu/gpu_video_service.cc
>  M  +  content/common/gpu/media/fake_gl_video_decode_engine.cc
>  M  +  content/common/gpu/media/fake_gl_video_device.h
>  M  +  content/common/gpu/media/fake_gl_video_device.cc
>  M  +  content/common/gpu/media/mft_angle_video_device.h
>  M  +  content/common/gpu/media/mft_angle_video_device.cc
>  A  +  content/common/gpu/x_util.h
>  A  +  content/common/gpu/x_util.cc
>  D     content/common/gpu_info.h
>  D     content/common/gpu_info.cc
>  D     content/common/gpu_info_unittest.cc
>  M     content/common/gpu_messages.h
>  M     content/content_common.gypi
>  M     content/content_gpu.gypi
>  D     content/gpu/OWNERS
>  D     content/gpu/content_gpu_client.h
>  D     content/gpu/gpu_channel.h
>  D     content/gpu/gpu_channel.cc
>  M     content/gpu/gpu_child_thread.h
>  M     content/gpu/gpu_child_thread.cc
>  D     content/gpu/gpu_command_buffer_stub.h
>  D     content/gpu/gpu_command_buffer_stub.cc
>  D     content/gpu/gpu_config.h
>  M     content/gpu/gpu_info_collector.h
>  M     content/gpu/gpu_info_collector_unittest.cc
>  M     content/gpu/gpu_info_unittest_win.cc
>  M     content/gpu/gpu_main.cc
>  D     content/gpu/gpu_render_thread.h
>  D     content/gpu/gpu_render_thread.cc
>  D     content/gpu/gpu_video_decoder.h
>  D     content/gpu/gpu_video_decoder.cc
>  D     content/gpu/gpu_video_decoder_unittest.cc
>  D     content/gpu/gpu_video_service.h
>  D     content/gpu/gpu_video_service.cc
>  D     content/gpu/media/fake_gl_video_decode_engine.h
>  D     content/gpu/media/fake_gl_video_decode_engine.cc
>  D     content/gpu/media/fake_gl_video_device.h
>  D     content/gpu/media/fake_gl_video_device.cc
>  D     content/gpu/media/gpu_video_device.h
>  D     content/gpu/media/mft_angle_video_device.h
>  D     content/gpu/media/mft_angle_video_device.cc
>  D     content/gpu/x_util.h
>  D     content/gpu/x_util.cc
>  M     content/renderer/gpu_channel_host.h
>
>
>

[Alexey Marinichev, 2011-04-06 00:00:56]

Renames are good, chrome/gpu dependency in content/browser/DEPS doesn't seem
right.

[apatrick, 2011-04-06 00:13:45]

On Tue, Apr 5, 2011 at 4:36 PM, John Abd-El-Malek <jam@chromium.org> wrote:

> Is there a specific part you want me to review?  I'm not familiar with the
> gpu code.
>
> Why would we want to move the code from content\gpu to chrome\gpu?  I moved
> it from chrome to content because this code belongs in content :)
>
> I need an OWNER to LGTM it. amarinichev is familiar with the gpu code and
has checked the renaming. I'd look at DEPS changes and whether I'm moving
these files to the right place.

I'm uploading patch set 3 with some fixes now.

Does GpuMain belong in content? The other process entry points are in
chrome.

[jam, 2011-04-06 00:17:08]

On Tue, Apr 5, 2011 at 5:13 PM, Alastair Patrick <apatrick@google.com>wrote:

>
>
> On Tue, Apr 5, 2011 at 4:36 PM, John Abd-El-Malek <jam@chromium.org>wrote:
>
>> Is there a specific part you want me to review?  I'm not familiar with the
>> gpu code.
>>
>> Why would we want to move the code from content\gpu to chrome\gpu?  I
>> moved it from chrome to content because this code belongs in content :)
>>
>> I need an OWNER to LGTM it. amarinichev is familiar with the gpu code and
> has checked the renaming. I'd look at DEPS changes and whether I'm moving
> these files to the right place.
>
> I'm uploading patch set 3 with some fixes now.
>
> Does GpuMain belong in content? The other process entry points are in
> chrome.
>

only because they have too many dependencies at the moment.  but note that
plugin, like gpu, is already in content.  we want the rest of the code to be
like that.  We want all the core code that handles rendering a page using a
multi-process sandboxed browser in content.  eventually, once all the chrome
dependencies are removed, we will have a test shell.  so we'll want to reuse
gpuprocess etc

[jam, 2011-04-08 01:03:20]

rubber stamp lgtm