gtk: Rename OnDialogResponse() to OnResponse() to standardize on a consistent naming scheme.

gtk: Rename OnDialogResponse() to OnResponse() to standardize on a consistent naming scheme.

This allow us to have a single pattern for handling the gtk "response" callback.

So now in every gtk dialog on chromium, it looks like this:

my_dialog_gtk.h:
CHROMEGTK_CALLBACK_1(MyDialogGtk, void, OnResponse, int);

my_dialog_gtk.cc:
void MyDialogGtk::OnResponse(GtkWidget* dialog, int response_id) {
}

And to subscribe to this event:
g_signal_connect(dialog_, "response", G_CALLBACK(OnResponseThunk), this);

BUG=None
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77180

[tfarina, 2011-03-06 00:54:11]

Hi guys, could you review this to me?

[tony, 2011-03-07 19:43:53]

LGTM

http://codereview.chromium.org/6627038/diff/36/chrome/browser/ui/gtk/hung_ren...
File chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc (right):

http://codereview.chromium.org/6627038/diff/36/chrome/browser/ui/gtk/hung_ren...
chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc:205:
gtk_widget_destroy(GTK_WIDGET(dialog_));
Nit: Remove GTK_WIDGET?

[tfarina, 2011-03-07 19:52:17]

http://codereview.chromium.org/6627038/diff/36/chrome/browser/ui/gtk/hung_ren...
File chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc (right):

http://codereview.chromium.org/6627038/diff/36/chrome/browser/ui/gtk/hung_ren...
chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc:205:
gtk_widget_destroy(GTK_WIDGET(dialog_));
On 2011/03/07 19:43:53, tony wrote:
> Nit: Remove GTK_WIDGET?

Nope, unfortunately |dialog_| is GtkDialog* 

And I couldn't convert it to GtkWidget, because we do dialog_->vbox; at line 97.

[tony, 2011-03-07 19:54:18]

http://codereview.chromium.org/6627038/diff/36/chrome/browser/ui/gtk/hung_ren...
File chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc (right):

http://codereview.chromium.org/6627038/diff/36/chrome/browser/ui/gtk/hung_ren...
chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc:205:
gtk_widget_destroy(GTK_WIDGET(dialog_));
On 2011/03/07 19:52:17, tfarina wrote:
> On 2011/03/07 19:43:53, tony wrote:
> > Nit: Remove GTK_WIDGET?
> 
> Nope, unfortunately |dialog_| is GtkDialog* 
> 
> And I couldn't convert it to GtkWidget, because we do dialog_->vbox; at line
97.

You could use |dialog| instead of |dialog_|.  If you wanted to be extra safe,
you could DCHECK that dialog == dialog_.

[tfarina, 2011-03-07 20:41:58]

On 2011/03/07 19:54:18, tony wrote:
> You could use |dialog| instead of |dialog_|.  If you wanted to be extra safe,
> you could DCHECK that dialog == dialog_.

Is it worth doing this?

DCHECK(dialog == GTK_WIDGET(dialog_));
gtk_widget_destroy(dialog);

[tony, 2011-03-07 20:44:25]

Your call.  I don't feel strongly one way or another.

On 2011/03/07 20:41:58, tfarina wrote:
> On 2011/03/07 19:54:18, tony wrote:
> > You could use |dialog| instead of |dialog_|.  If you wanted to be extra
safe,
> > you could DCHECK that dialog == dialog_.
> 
> Is it worth doing this?
> 
> DCHECK(dialog == GTK_WIDGET(dialog_));
> gtk_widget_destroy(dialog);

[tfarina, 2011-03-07 20:46:43]

On 2011/03/07 20:44:25, tony wrote:
> Your call.  I don't feel strongly one way or another.
> 
I guess the right fix is to convert |dialog_| to GtkWidget and then fix the line
97. I'm going to leave it as is.