chrome/browser/ui/gtk/keyword_editor_view.cc - Issue 6627038: gtk: Rename OnDialogResponse() to OnResponse() to standardize on a consistent naming scheme.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/keyword_editor_view.cc

Issue 6627038: gtk: Rename OnDialogResponse() to OnResponse() to standardize on a consistent naming scheme. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc ('K') | « chrome/browser/ui/gtk/keyword_editor_view.h ('k') | chrome/browser/ui/gtk/options/content_exception_editor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/keyword_editor_view.cc

diff --git a/chrome/browser/ui/gtk/keyword_editor_view.cc b/chrome/browser/ui/gtk/keyword_editor_view.cc

index c0a5acdcdd9e31e367eddc0e3fcf14b39cfe2edd..f1777d261f9192f5f29e684d035d3ea02fadb77b 100644

--- a/chrome/browser/ui/gtk/keyword_editor_view.cc

+++ b/chrome/browser/ui/gtk/keyword_editor_view.cc

@@ -197,7 +197,7 @@ void KeywordEditorView::Init() {

EnableControls();

- g_signal_connect(dialog_, "response", G_CALLBACK(OnResponse), this);

+ g_signal_connect(dialog_, "response", G_CALLBACK(OnResponseThunk), this);

g_signal_connect(dialog_, "destroy", G_CALLBACK(OnWindowDestroy), this);

}

@@ -396,10 +396,8 @@ void KeywordEditorView::OnWindowDestroy(GtkWidget* widget,

MessageLoop::current()->DeleteSoon(FROM_HERE, window);

}

-// static

-void KeywordEditorView::OnResponse(GtkDialog* dialog, int response_id,

- KeywordEditorView* window) {

- gtk_widget_destroy(window->dialog_);

+void KeywordEditorView::OnResponse(GtkWidget* dialog, int response_id) {

+ gtk_widget_destroy(dialog_);

}

// static