chrome/browser/ui/gtk/certificate_viewer.cc - Issue 6627038: gtk: Rename OnDialogResponse() to OnResponse() to standardize on a consistent naming scheme.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/certificate_viewer.cc

Issue 6627038: gtk: Rename OnDialogResponse() to OnResponse() to standardize on a consistent naming scheme. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/gtk/about_chrome_dialog.cc ('k') | chrome/browser/ui/gtk/clear_browsing_data_dialog_gtk.h » ('j') | chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/certificate_viewer.cc

diff --git a/chrome/browser/ui/gtk/certificate_viewer.cc b/chrome/browser/ui/gtk/certificate_viewer.cc

index ab64d2af3d5e55f291e3d361546e7815ed8455d3..04b1a260739b784d23c80028f4744230ea9f0be3 100644

--- a/chrome/browser/ui/gtk/certificate_viewer.cc

+++ b/chrome/browser/ui/gtk/certificate_viewer.cc

@@ -121,10 +121,9 @@ class CertificateViewer {

// CertificateViewer implementation.

// Close button callback.

-void OnDialogResponse(GtkDialog* dialog, gint response_id,

- gpointer user_data) {

+void OnResponse(GtkWidget* dialog, int response_id) {

// "Close" was clicked.

- gtk_widget_destroy(GTK_WIDGET(dialog));

+ gtk_widget_destroy(dialog);

}

void OnDestroy(GtkDialog* dialog, CertificateViewer* cert_viewer) {

@@ -173,7 +172,7 @@ CertificateViewer::CertificateViewer(

l10n_util::GetStringUTF8(

IDS_CERT_INFO_DETAILS_TAB_LABEL)).c_str()));

- g_signal_connect(dialog_, "response", G_CALLBACK(OnDialogResponse), NULL);

+ g_signal_connect(dialog_, "response", G_CALLBACK(OnResponse), NULL);

g_signal_connect(dialog_, "destroy", G_CALLBACK(OnDestroy), this);

}