gtk: Rename OnDialogResponse() to OnResponse() to standardize on a consistent naming scheme.

chrome/browser/ui/gtk/external_protocol_dialog_gtk.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/gtk/external_protocol_dialog_gtk.h"
 
 #include <gtk/gtk.h>
 
 #include <string>
 
@@ skipping 80 matching lines @@
   // Add the checkbox.
   checkbox_ = gtk_check_button_new_with_label(
       l10n_util::GetStringUTF8(IDS_EXTERNAL_PROTOCOL_CHECKBOX_TEXT).c_str());
   gtk_box_pack_start(GTK_BOX(vbox), checkbox_,
                      FALSE, FALSE, 0);
 
   // Add our vbox to the dialog.
   gtk_box_pack_start(GTK_BOX(GTK_DIALOG(dialog_)->vbox), vbox,
                      FALSE, FALSE, 0);
 
-  g_signal_connect(dialog_, "response",
-                   G_CALLBACK(OnDialogResponseThunk), this);
+  g_signal_connect(dialog_, "response", G_CALLBACK(OnResponseThunk), this);
 
   gtk_window_set_resizable(GTK_WINDOW(dialog_), FALSE);
   gtk_widget_show_all(dialog_);
 }
 
-void ExternalProtocolDialogGtk::OnDialogResponse(GtkWidget* widget,
-                                                 int response) {
+ExternalProtocolDialogGtk::~ExternalProtocolDialogGtk() {
+}
+
+void ExternalProtocolDialogGtk::OnResponse(GtkWidget* dialog, int response_id) {
   if (gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(checkbox_))) {
-    if (response == GTK_RESPONSE_ACCEPT) {
+    if (response_id == GTK_RESPONSE_ACCEPT) {
       ExternalProtocolHandler::SetBlockState(
           url_.scheme(), ExternalProtocolHandler::DONT_BLOCK);
-    } else if (response == GTK_RESPONSE_REJECT) {
+    } else if (response_id == GTK_RESPONSE_REJECT) {
       ExternalProtocolHandler::SetBlockState(
           url_.scheme(), ExternalProtocolHandler::BLOCK);
     }
     // If the response is GTK_RESPONSE_DELETE, triggered by the user closing
     // the dialog, do nothing.
   }
 
-  if (response == GTK_RESPONSE_ACCEPT) {
+  if (response_id == GTK_RESPONSE_ACCEPT) {
     UMA_HISTOGRAM_LONG_TIMES("clickjacking.launch_url",
                              base::TimeTicks::Now() - creation_time_);
 
     ExternalProtocolHandler::LaunchUrlWithoutSecurityCheck(url_);
   }
 
   gtk_widget_destroy(dialog_);
   delete this;
 }