gtk: Rename OnDialogResponse() to OnResponse() to standardize on a consistent naming scheme.

chrome/browser/ui/gtk/hung_renderer_dialog_gtk.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_dialogs.h"
 
 #include <gtk/gtk.h>
 
 #include "base/process_util.h"
 #include "base/utf_string_conversions.h"
@@ skipping 26 matching lines @@
   // The GtkTreeView column ids.
   enum {
     COL_FAVICON,
     COL_TITLE,
     COL_COUNT,
   };
 
   // Create the gtk dialog and add the widgets.
   void Init();
 
-  CHROMEGTK_CALLBACK_1(HungRendererDialogGtk, void, OnDialogResponse, gint);
+  CHROMEGTK_CALLBACK_1(HungRendererDialogGtk, void, OnResponse, int);
 
   GtkDialog* dialog_;
   GtkListStore* model_;
   TabContents* contents_;
 
   DISALLOW_COPY_AND_ASSIGN(HungRendererDialogGtk);
 };
 
 // We only support showing one of these at a time per app.
 HungRendererDialogGtk* g_instance = NULL;
@@ skipping 11 matching lines @@
   dialog_ = GTK_DIALOG(gtk_dialog_new_with_buttons(
       l10n_util::GetStringUTF8(IDS_BROWSER_HANGMONITOR_RENDERER_TITLE).c_str(),
       NULL,  // No parent because tabs can span multiple windows.
       GTK_DIALOG_NO_SEPARATOR,
       l10n_util::GetStringUTF8(IDS_BROWSER_HANGMONITOR_RENDERER_END).c_str(),
       kKillPagesButtonResponse,
       l10n_util::GetStringUTF8(IDS_BROWSER_HANGMONITOR_RENDERER_WAIT).c_str(),
       GTK_RESPONSE_OK,
       NULL));
   gtk_dialog_set_default_response(dialog_, GTK_RESPONSE_OK);
-  g_signal_connect(dialog_, "response",
-                   G_CALLBACK(OnDialogResponseThunk), this);
+  g_signal_connect(dialog_, "response", G_CALLBACK(OnResponseThunk), this);
 
   // We have an hbox with the frozen icon on the left.  On the right,
   // we have a vbox with the unresponsive text on top and a table of
   // tabs on bottom.
   // ·-----------------------------------·
   // |·---------------------------------·|
   // ||·----·|·------------------------·||
   // |||icon|||                        |||
   // ||·----·|| The folowing page(s).. |||
   // ||      ||                        |||
@@ skipping 84 matching lines @@
   if (contents_ && contents_->GetRenderProcessHost() ==
       contents->GetRenderProcessHost()) {
     gtk_widget_hide(GTK_WIDGET(dialog_));
     // Since we're closing, we no longer need this TabContents.
     contents_ = NULL;
   }
 }
 
 // When the user clicks a button on the dialog or closes the dialog, this
 // callback is called.
-void HungRendererDialogGtk::OnDialogResponse(GtkWidget* widget,
-                                             gint response_id) {
+void HungRendererDialogGtk::OnResponse(GtkWidget* dialog, int response_id) {
   DCHECK(g_instance == this);
   switch (response_id) {
     case kKillPagesButtonResponse:
       // Kill the process.
       if (contents_ && contents_->GetRenderProcessHost()) {
         base::KillProcess(contents_->GetRenderProcessHost()->GetHandle(),
                           ResultCodes::HUNG, false);
       }
       break;
 
     case GTK_RESPONSE_OK:
     case GTK_RESPONSE_DELETE_EVENT:
       // Start waiting again for responsiveness.
       if (contents_ && contents_->render_view_host())
         contents_->render_view_host()->RestartHangMonitorTimeout();
       break;
     default:
       NOTREACHED();
   }
 
   gtk_widget_destroy(GTK_WIDGET(dialog_));

[tony, 2011/03/07 19:43:53]

Nit: Remove GTK_WIDGET?

[tfarina, 2011/03/07 19:52:17]

Nope, unfortunately |dialog_| is GtkDialog* 

And I couldn't convert it to GtkWidget, because we do dialog_->vbox; at line 97.

[tony, 2011/03/07 19:54:18]

You could use |dialog| instead of |dialog_|.  If you wanted to be extra safe,
you could DCHECK that dialog == dialog_.

   delete g_instance;
   g_instance = NULL;
 }
 
 }  // namespace
 
 namespace browser {
 
 void ShowHungRendererDialog(TabContents* contents) {
   if (!logging::DialogsAreSuppressed()) {
     if (!g_instance)
       g_instance = new HungRendererDialogGtk();
     g_instance->ShowForTabContents(contents);
   }
 }
 
 void HideHungRendererDialog(TabContents* contents) {
   if (!logging::DialogsAreSuppressed() && g_instance)
     g_instance->EndForTabContents(contents);
 }
 
 }  // namespace browser