Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6383)

Unified Diff: chrome/browser/ui/gtk/clear_browsing_data_dialog_gtk.cc

Issue 6627038: gtk: Rename OnDialogResponse() to OnResponse() to standardize on a consistent naming scheme. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/clear_browsing_data_dialog_gtk.cc
diff --git a/chrome/browser/ui/gtk/clear_browsing_data_dialog_gtk.cc b/chrome/browser/ui/gtk/clear_browsing_data_dialog_gtk.cc
index 16f546c0b2d36c34e04d2616609267c0fc0616ce..328d3cb3c49fa20091103f884844ed90bfa32a81 100644
--- a/chrome/browser/ui/gtk/clear_browsing_data_dialog_gtk.cc
+++ b/chrome/browser/ui/gtk/clear_browsing_data_dialog_gtk.cc
@@ -169,8 +169,7 @@ ClearBrowsingDataDialogGtk::ClearBrowsingDataDialogGtk(GtkWindow* parent,
gtk_box_reorder_child(GTK_BOX(content_area), GTK_DIALOG(dialog_)->action_area,
-1);
- g_signal_connect(dialog_, "response",
- G_CALLBACK(OnDialogResponseThunk), this);
+ g_signal_connect(dialog_, "response", G_CALLBACK(OnResponseThunk), this);
UpdateDialogButtons();
@@ -181,9 +180,9 @@ ClearBrowsingDataDialogGtk::ClearBrowsingDataDialogGtk(GtkWindow* parent,
ClearBrowsingDataDialogGtk::~ClearBrowsingDataDialogGtk() {
}
-void ClearBrowsingDataDialogGtk::OnDialogResponse(GtkWidget* widget,
- int response) {
- if (response == GTK_RESPONSE_ACCEPT) {
+void ClearBrowsingDataDialogGtk::OnResponse(GtkWidget* dialog,
+ int response_id) {
+ if (response_id == GTK_RESPONSE_ACCEPT) {
PrefService* prefs = profile_->GetPrefs();
prefs->SetBoolean(prefs::kDeleteBrowsingHistory,
IsChecked(del_history_checkbox_));
@@ -211,7 +210,7 @@ void ClearBrowsingDataDialogGtk::OnDialogResponse(GtkWidget* widget,
}
delete this;
- gtk_widget_destroy(GTK_WIDGET(widget));
+ gtk_widget_destroy(dialog);
}
void ClearBrowsingDataDialogGtk::OnDialogWidgetClicked(GtkWidget* widget) {

Powered by Google App Engine
This is Rietveld 408576698