Change other usages of .size() to .empty() when applicable.

Change other usages of .size() to .empty() when applicable.

BUG=carnitas
TEST=compiles

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76962

[Elliot Glaysher, 2011-03-03 18:58:20]

You'll find that all the nits from the last code review (sans ones in o3d/) have
been rolled into this CL (I interpreted 'Awesome!' as a LG; sorry)

I'm ignoring o3d/ since that code is supposed to go away Real Soon Now.

[Peter Kasting, 2011-03-03 19:35:52]

LGTM.  I found some more patterns for you to search the codebase for :D

http://codereview.chromium.org/6609008/diff/2001/chrome/browser/accessibility...
File chrome/browser/accessibility/browser_accessibility_win.cc (right):

http://codereview.chromium.org/6609008/diff/2001/chrome/browser/accessibility...
chrome/browser/accessibility/browser_accessibility_win.cc:119: LONG nav_dir,
VARIANT start, VARIANT* end) {
Nit: There are multiple different param indenting issues in this file (see here
and get_accChild() below for example), feel free to fix :(

http://codereview.chromium.org/6609008/diff/2001/chrome/browser/accessibility...
chrome/browser/accessibility/browser_accessibility_win.cc:144: result =
target->children_[target->children_.size() - 1];
Nit:

        result = target->children_.back();

(Might want to change the case above to use .front() for parallelism)

http://codereview.chromium.org/6609008/diff/2001/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/wizard_accessibility_handler.cc (right):

http://codereview.chromium.org/6609008/diff/2001/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/wizard_accessibility_handler.cc:433: if
(!inserted.empty() && !deleted.empty()) {
Nit: It seems like this first conditional + arm can just disappear since the
body is the same as the arm below.

Unless this is a bug?

http://codereview.chromium.org/6609008/diff/2001/chrome/browser/download/down...
File chrome/browser/download/download_util.cc (right):

http://codereview.chromium.org/6609008/diff/2001/chrome/browser/download/down...
chrome/browser/download/download_util.cc:116: if (!extension_lower.empty() &&
extension_lower.at(0) == L'{' &&
Nit: at() -> [] (this would be another good change to automate throughout the
codebase)

http://codereview.chromium.org/6609008/diff/2001/chrome/browser/sync/glue/for...
File chrome/browser/sync/glue/foreign_session_tracker.cc (left):

http://codereview.chromium.org/6609008/diff/2001/chrome/browser/sync/glue/for...
chrome/browser/sync/glue/foreign_session_tracker.cc:36: return false;
Heh.  "if (x) return true; else return false;" and its opposite are more good
patterns to do an automated search for.

http://codereview.chromium.org/6609008/diff/2001/chrome/browser/ui/webui/bug_...
File chrome/browser/ui/webui/bug_report_ui.cc (right):

http://codereview.chromium.org/6609008/diff/2001/chrome/browser/ui/webui/bug_...
chrome/browser/ui/webui/bug_report_ui.cc:636: if (!screenshot_path.empty()) {
Nit: No need for {}

http://codereview.chromium.org/6609008/diff/2001/chrome/browser/ui/webui/bug_...
chrome/browser/ui/webui/bug_report_ui.cc:665:
bug_report_->UpdateData(web_ui_->GetProfile()
Nit: While here, want to fix where the commas are?

http://codereview.chromium.org/6609008/diff/2001/chrome_frame/chrome_frame_au...
File chrome_frame/chrome_frame_automation.cc (right):

http://codereview.chromium.org/6609008/diff/2001/chrome_frame/chrome_frame_au...
chrome_frame/chrome_frame_automation.cc:1013: if (!functions_enabled.empty()) {
Nit: No need for {}

http://codereview.chromium.org/6609008/diff/2001/net/base/dnssec_chain_verifi...
File net/base/dnssec_chain_verifier.cc (right):

http://codereview.chromium.org/6609008/diff/2001/net/base/dnssec_chain_verifi...
net/base/dnssec_chain_verifier.cc:735: if (!digest.empty()) {
Nit:

    lookahead[i] = digest.empty();
    if (!digest.empty())
      (*rrdatas)[i] = digest;

http://codereview.chromium.org/6609008/diff/2001/net/url_request/url_request_...
File net/url_request/url_request_throttler_entry.cc (right):

http://codereview.chromium.org/6609008/diff/2001/net/url_request/url_request_...
net/url_request/url_request_throttler_entry.cc:77: if (!send_log_.empty() &&
Nit: This will all fit on one line, then can eliminate {}

http://codereview.chromium.org/6609008/diff/2001/remoting/jingle_glue/jingle_...
File remoting/jingle_glue/jingle_thread.cc (right):

http://codereview.chromium.org/6609008/diff/2001/remoting/jingle_glue/jingle_...
remoting/jingle_glue/jingle_thread.cc:166: if (!msgq_.empty() || fPeekKeep_) {
Nit: No need for {}

http://codereview.chromium.org/6609008/diff/2001/webkit/plugins/npapi/plugin_...
File webkit/plugins/npapi/plugin_lib_mac.mm (right):

http://codereview.chromium.org/6609008/diff/2001/webkit/plugins/npapi/plugin_...
webkit/plugins/npapi/plugin_lib_mac.mm:222: if (have_plugin_descs &&
!plugin_descs.empty())
Nit:

  info->desc = UTF8ToUTF16((have_plugin_descs && !plugin_descs.empty()) ?
      plugin_descs[0] : filename.BaseName().value());