Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: chrome/test/reliability/page_load_test.cc

Issue 6609008: Change other usages of .size() to .empty() when applicable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Peter nits Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/renderer/webworker_base.h ('k') | chrome/test/url_fetch_test/url_fetch_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This file provides reliablity test which runs under UI test framework. The 5 // This file provides reliablity test which runs under UI test framework. The
6 // test is intended to run within QEMU environment. 6 // test is intended to run within QEMU environment.
7 // 7 //
8 // Usage 1: reliability_test 8 // Usage 1: reliability_test
9 // Upon invocation, it visits a hard coded list of sample URLs. This is mainly 9 // Upon invocation, it visits a hard coded list of sample URLs. This is mainly
10 // used by buildbot, to verify reliability_test itself runs ok. 10 // used by buildbot, to verify reliability_test itself runs ok.
(...skipping 273 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 break; 284 break;
285 } 285 }
286 286
287 // Get crash dumps - don't delete them if logging. 287 // Get crash dumps - don't delete them if logging.
288 std::vector<FilePath> new_crash_dumps; 288 std::vector<FilePath> new_crash_dumps;
289 CollectNewCrashDumps(new_crash_dumps, &metrics, !log_file.is_open()); 289 CollectNewCrashDumps(new_crash_dumps, &metrics, !log_file.is_open());
290 290
291 bool do_log = log_file.is_open() && 291 bool do_log = log_file.is_open() &&
292 (!log_only_error || 292 (!log_only_error ||
293 metrics.result != NAVIGATION_SUCCESS || 293 metrics.result != NAVIGATION_SUCCESS ||
294 new_crash_dumps.size() > 0); 294 !new_crash_dumps.empty());
295 if (do_log) { 295 if (do_log) {
296 log_file << url_string; 296 log_file << url_string;
297 switch (metrics.result) { 297 switch (metrics.result) {
298 case NAVIGATION_ERROR: 298 case NAVIGATION_ERROR:
299 log_file << " error"; 299 log_file << " error";
300 break; 300 break;
301 case NAVIGATION_SUCCESS: 301 case NAVIGATION_SUCCESS:
302 log_file << " success"; 302 log_file << " success";
303 break; 303 break;
304 case NAVIGATION_AUTH_NEEDED: 304 case NAVIGATION_AUTH_NEEDED:
(...skipping 515 matching lines...) Expand 10 before | Expand all | Expand 10 after
820 } 820 }
821 } 821 }
822 822
823 if (parsed_command_line.HasSwitch(kStressOptSwitch)) { 823 if (parsed_command_line.HasSwitch(kStressOptSwitch)) {
824 g_stress_opt = true; 824 g_stress_opt = true;
825 } 825 }
826 if (parsed_command_line.HasSwitch(kStressDeoptSwitch)) { 826 if (parsed_command_line.HasSwitch(kStressDeoptSwitch)) {
827 g_stress_deopt = true; 827 g_stress_deopt = true;
828 } 828 }
829 } 829 }
OLDNEW
« no previous file with comments | « chrome/renderer/webworker_base.h ('k') | chrome/test/url_fetch_test/url_fetch_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698