chrome/common/extensions/extension_icon_set.cc - Issue 6609008: Change other usages of .size() to .empty() when applicable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_icon_set.cc

Issue 6609008: Change other usages of .size() to .empty() when applicable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Peter nits Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/extension_icon_set.cc

diff --git a/chrome/common/extensions/extension_icon_set.cc b/chrome/common/extensions/extension_icon_set.cc

index fc1ac58860eca4ba7eb4dff704498db97b50991e..9b47c7dea2ebe1b9f47b05c0712c4379dedf80e0 100644

--- a/chrome/common/extensions/extension_icon_set.cc

+++ b/chrome/common/extensions/extension_icon_set.cc

@@ -15,7 +15,7 @@ void ExtensionIconSet::Clear() {

}

void ExtensionIconSet::Add(int size, const std::string& path) {

- CHECK(path.size() > 0 && path[0] != '/');

+ CHECK(!path.empty() && path[0] != '/');

map_[size] = path;

}

« no previous file with comments | « chrome/common/extensions/extension.cc ('k') | chrome/common/extensions/update_manifest.cc » ('j') | no next file with comments »