Change other usages of .size() to .empty() when applicable.

chrome/browser/accessibility/browser_accessibility_win.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/accessibility/browser_accessibility_win.h"
 
 #include "base/string_number_conversions.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/accessibility/browser_accessibility_manager_win.h"
@@ skipping 98 matching lines @@
   gfx::Rect bounds = target->GetBoundsRect();
   *x_left = bounds.x();
   *y_top  = bounds.y();
   *width  = bounds.width();
   *height = bounds.height();
 
   return S_OK;
 }
 
 STDMETHODIMP BrowserAccessibilityWin::accNavigate(
     LONG nav_dir, VARIANT start, VARIANT* end) {

[Peter Kasting, 2011/03/03 19:35:53]

Nit: There are multiple different param indenting issues in this file (see here
and get_accChild() below for example), feel free to fix :(

   BrowserAccessibilityWin* target = GetTargetFromChildID(start);
   if (!target)
     return E_INVALIDARG;
 
   if ((nav_dir == NAVDIR_LASTCHILD || nav_dir == NAVDIR_FIRSTCHILD) &&
       start.lVal != CHILDID_SELF) {
     // MSAA states that navigating to first/last child can only be from self.
     return E_INVALIDARG;
   }
 
   BrowserAccessibility* result = NULL;
   switch (nav_dir) {
     case NAVDIR_DOWN:
     case NAVDIR_UP:
     case NAVDIR_LEFT:
     case NAVDIR_RIGHT:
       // These directions are not implemented, matching Mozilla and IE.
       return E_NOTIMPL;
     case NAVDIR_FIRSTCHILD:
-      if (target->children_.size() > 0)
+      if (!target->children_.empty())
         result = target->children_[0];
       break;
     case NAVDIR_LASTCHILD:
-      if (target->children_.size() > 0)
+      if (!target->children_.empty())
         result = target->children_[target->children_.size() - 1];

[Peter Kasting, 2011/03/03 19:35:53]

Nit:

        result = target->children_.back();

(Might want to change the case above to use .front() for parallelism)

       break;
     case NAVDIR_NEXT:
       result = target->GetNextSibling();
       break;
     case NAVDIR_PREVIOUS:
       result = target->GetPreviousSibling();
       break;
   }
 
   if (!result) {
@@ skipping 1442 matching lines @@
   }
 
   // The role should always be set.
   DCHECK(!role_name_.empty() || ia_role_);
 
   // If we didn't explicitly set the IAccessible2 role, make it the same
   // as the MSAA role.
   if (!ia2_role_)
     ia2_role_ = ia_role_;
 }