base/string_util.cc - Issue 6609008: Change other usages of .size() to .empty() when applicable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/string_util.cc

Issue 6609008: Change other usages of .size() to .empty() when applicable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Peter nits Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/string_util.cc

diff --git a/base/string_util.cc b/base/string_util.cc

index 4af3ed9b062ff60951f75a0de5d5b93b2579b780..af96d914f51904fdd6adadc33106754e119834cd 100644

--- a/base/string_util.cc

+++ b/base/string_util.cc

@@ -804,7 +804,8 @@ size_t Tokenize(const base::StringPiece& str,

template<typename STR>

static STR JoinStringT(const std::vector<STR>& parts,

typename STR::value_type sep) {

- if (parts.empty()) return STR();

+ if (parts.empty())

+ return STR();

STR result(parts[0]);

typename std::vector<STR>::const_iterator iter = parts.begin();