chrome/browser/importer/firefox2_importer.cc - Issue 6609008: Change other usages of .size() to .empty() when applicable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/importer/firefox2_importer.cc

Issue 6609008: Change other usages of .size() to .empty() when applicable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Peter nits Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/importer/firefox2_importer.cc

diff --git a/chrome/browser/importer/firefox2_importer.cc b/chrome/browser/importer/firefox2_importer.cc

index bf68af07079408844641f3cc7f99b062bce125fb..31ea3a302d1749386b76438ba288fb0bd10ff36b 100644

--- a/chrome/browser/importer/firefox2_importer.cc

+++ b/chrome/browser/importer/firefox2_importer.cc

@@ -205,7 +205,7 @@ void Firefox2Importer::ImportBookmarksFile(

post_data.empty() &&

CanImportURL(GURL(url)) &&

default_urls.find(url) == default_urls.end()) {

- if (toolbar_folder > path.size() && path.size() > 0) {

+ if (toolbar_folder > path.size() && !path.empty()) {

NOTREACHED(); // error in parsing.

break;

}

« no previous file with comments | « chrome/browser/history/query_parser.cc ('k') | chrome/browser/importer/ie_importer.cc » ('j') | no next file with comments »