It turns out I had the sense of the GetLocalBounds bool wrong everywhere, so ...

It turns out I had the sense of the GetLocalBounds bool wrong everywhere, so invert everything.

This fixes the painting bugs in the omnibox and bookmark bar, and probably countless other glitches in rendering.

BUG=none
TEST=omnibox popup should render properly
TBR=sky


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74231

[sadrul, 2011-02-09 05:52:28]

http://codereview.chromium.org/6462022/diff/1/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/6462022/diff/1/chrome/chrome_browser.gypi#newc...
chrome/chrome_browser.gypi:3934: '../views/views.gyp:*',
Out of curiosity, are the changes in this file intentional?
views_unittests/views_examples probably shouldn't be dependencies for chrome?

[Ben Goodger (Google), 2011-02-09 06:02:14]

Yes intentional. Chrome is a common sln for frontend developers and it was
hard to find the views tests.

-Ben

On Tue, Feb 8, 2011 at 9:52 PM, <sadrul@chromium.org> wrote:

>
> http://codereview.chromium.org/6462022/diff/1/chrome/chrome_browser.gypi
> File chrome/chrome_browser.gypi (right):
>
>
>
http://codereview.chromium.org/6462022/diff/1/chrome/chrome_browser.gypi#newc...
> chrome/chrome_browser.gypi:3934: '../views/views.gyp:*',
> Out of curiosity, are the changes in this file intentional?
> views_unittests/views_examples probably shouldn't be dependencies for
> chrome?
>
> http://codereview.chromium.org/6462022/
>

[piman, 2011-02-22 20:27:19]

On 2011/02/09 06:02:14, Ben Goodger wrote:
> Yes intentional. Chrome is a common sln for frontend developers and it was
> hard to find the views tests.

The impact on that is that building chromeos chrome now needs to build the views
unit tests, including its dependencies (e.g. gtest, gmock etc.) which increases
build time (linking them in debug takes long). Can we revert that part, at least
on linux ?

> 
> -Ben
> 
> On Tue, Feb 8, 2011 at 9:52 PM, <mailto:sadrul@chromium.org> wrote:
> 
> >
> > http://codereview.chromium.org/6462022/diff/1/chrome/chrome_browser.gypi
> > File chrome/chrome_browser.gypi (right):
> >
> >
> >
>
http://codereview.chromium.org/6462022/diff/1/chrome/chrome_browser.gypi#newc...
> > chrome/chrome_browser.gypi:3934: '../views/views.gyp:*',
> > Out of curiosity, are the changes in this file intentional?
> > views_unittests/views_examples probably shouldn't be dependencies for
> > chrome?
> >
> > http://codereview.chromium.org/6462022/
> >