views/controls/button/menu_button.cc - Issue 6462022: It turns out I had the sense of the GetLocalBounds bool wrong everywhere, so ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: views/controls/button/menu_button.cc

Issue 6462022: It turns out I had the sense of the GetLocalBounds bool wrong everywhere, so ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: views/controls/button/menu_button.cc

===================================================================

--- views/controls/button/menu_button.cc (revision 74228)

+++ views/controls/button/menu_button.cc (working copy)

@@ -126,7 +126,7 @@

// after the menu closes.

PaintNow();

if (menu_delegate_) {

- gfx::Rect lb = GetContentsBounds();

+ gfx::Rect lb = GetLocalBounds();

// The position of the menu depends on whether or not the locale is

// right-to-left.

« chrome/chrome_browser.gypi ('K') | « views/controls/button/checkbox.cc ('k') | views/controls/label_unittest.cc » ('j') | no next file with comments »