Replace DCHECKs on InserCode and Navigate paths with LOG(ERROR)

These DCHECKs are sort-of expected in a fast startup sequence.
They are still errors, but DCHECKs make use of automated testing tools against the debug build virtually impossible.
This will be followed-up. 

BUG=66863
BUG=66864
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69170

[mad-corp, 2010-12-14 13:38:19]

LGTM with two requests...

BYE
MAD

http://codereview.chromium.org/5751001/diff/5001/ceee/ie/broker/tab_api_modul...
File ceee/ie/broker/tab_api_module.cc (right):

http://codereview.chromium.org/5751001/diff/5001/ceee/ie/broker/tab_api_modul...
ceee/ie/broker/tab_api_module.cc:977: LOG(WARNING) << "Failed to create tab. "
<< com::LogHr(hr);
This should be at least ERROR... And I actually think the DCHECK IS important
here... If we have cases where it is legit to fail, we should DCHECK on those
cases (e.g., the window into which we are attempting to create a new tab is
going away)... It could also be that it's the tab we are trying to use as the
source of the navigation that is going away, and we may be able to use another
one...

I think a TODO isn't enough here, we should file a bug for this... And bump up
the error level... If the DCHECK is problematic, then LOG(ERROR | FATAL)...

http://codereview.chromium.org/5751001/diff/5001/ceee/ie/plugin/bho/browser_h...
File ceee/ie/plugin/bho/browser_helper_object.cc (right):

http://codereview.chromium.org/5751001/diff/5001/ceee/ie/plugin/bho/browser_h...
ceee/ie/plugin/bho/browser_helper_object.cc:172: LOG(INFO) << "BHO's set site
called with " << site;
Please use VLOG(1)

[mad-corp, 2010-12-14 13:39:21]

Oh, and update the CL title so that it doesn't look that it's only for the
insert code path since you also have a fix for the create tab path...

Thanks!

BYE
MAD

[motek., 2010-12-14 14:44:04]

Addressed all comments. Please note this is work in progress. Both issues will
remain open.