Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ceee/ie/plugin/bho/executor.cc

Issue 5751001: Replace DCHECKs on InserCode and Navigate paths with LOG(ERROR) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ceee/ie/plugin/bho/browser_helper_object.cc ('K') | « ceee/ie/plugin/bho/browser_helper_object.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ceee/ie/plugin/bho/executor.cc
===================================================================
--- ceee/ie/plugin/bho/executor.cc (revision 68734)
+++ ceee/ie/plugin/bho/executor.cc (working copy)
@@ -877,7 +877,7 @@
hr = frame_handler_host->InsertCode(code, file, all_frames, type);
if (FAILED(hr)) {
- NOTREACHED() << "Failed to insert code. " << com::LogHr(hr);
+ LOG(ERROR) << "Failed to insert code. " << com::LogHr(hr);
return hr;
}
« ceee/ie/plugin/bho/browser_helper_object.cc ('K') | « ceee/ie/plugin/bho/browser_helper_object.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698