Chromium Code Reviews| Index: ceee/ie/plugin/bho/browser_helper_object.cc |
| =================================================================== |
| --- ceee/ie/plugin/bho/browser_helper_object.cc (revision 68734) |
| +++ ceee/ie/plugin/bho/browser_helper_object.cc (working copy) |
| @@ -169,6 +169,7 @@ |
| STDMETHODIMP BrowserHelperObject::SetSite(IUnknown* site) { |
| typedef IObjectWithSiteImpl<BrowserHelperObject> SuperSite; |
| + LOG(INFO) << "BHO's set site called with " << site; |
|
mad-corp
2010/12/14 13:38:20
Please use VLOG(1)
|
| // From experience, we know the site may be set multiple times. |
| // Let's ignore second and subsequent set or unset. |
| @@ -1485,7 +1486,10 @@ |
| } else if (web_browser_ != NULL) { |
| ScopedFrameEventHandlerPtr handler; |
| HRESULT hr = GetBrowserHandler(web_browser_, handler.Receive()); |
| - DCHECK(SUCCEEDED(hr) && handler != NULL) << com::LogHr(hr); |
| + LOG_IF(ERROR, FAILED(hr) || handler == NULL) << |
| + "GetBrowserHandler fails in InsertCode: " << com::LogHr(hr); |
| + if (FAILED(hr)) |
| + return hr; |
| if (handler != NULL) { |
| hr = handler->InsertCode(code, file, type); |