Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Unified Diff: ceee/ie/plugin/bho/browser_helper_object.cc

Issue 5751001: Replace DCHECKs on InserCode and Navigate paths with LOG(ERROR) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ceee/ie/plugin/bho/browser_helper_object.cc
===================================================================
--- ceee/ie/plugin/bho/browser_helper_object.cc (revision 68734)
+++ ceee/ie/plugin/bho/browser_helper_object.cc (working copy)
@@ -169,6 +169,7 @@
STDMETHODIMP BrowserHelperObject::SetSite(IUnknown* site) {
typedef IObjectWithSiteImpl<BrowserHelperObject> SuperSite;
+ LOG(INFO) << "BHO's set site called with " << site;
mad-corp 2010/12/14 13:38:20 Please use VLOG(1)
// From experience, we know the site may be set multiple times.
// Let's ignore second and subsequent set or unset.
@@ -1485,7 +1486,10 @@
} else if (web_browser_ != NULL) {
ScopedFrameEventHandlerPtr handler;
HRESULT hr = GetBrowserHandler(web_browser_, handler.Receive());
- DCHECK(SUCCEEDED(hr) && handler != NULL) << com::LogHr(hr);
+ LOG_IF(ERROR, FAILED(hr) || handler == NULL) <<
+ "GetBrowserHandler fails in InsertCode: " << com::LogHr(hr);
+ if (FAILED(hr))
+ return hr;
if (handler != NULL) {
hr = handler->InsertCode(code, file, type);

Powered by Google App Engine
This is Rietveld 408576698