Replace DCHECKs on InserCode and Navigate paths with LOG(ERROR)

ceee/ie/broker/tab_api_module.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Tab API implementation.
 //
 // Tab IDs are the window handle of the "TabWindowClass" window class
 // of the whole tab.
 //
 // To find the chrome.window.* "window ID" we can just get the top-level parent
@@ skipping 951 matching lines @@
                             reinterpret_cast<void**>(executor.Receive()));
     if (executor == NULL) {
       LOG(WARNING) << "Failed to get an executor to create a tab.";
       result->PostError("Internal error while trying to create tab.");
       return;
     }
 
     long flags = selected ? navOpenInNewTab : navOpenInBackgroundTab;
     HRESULT hr = executor->Navigate(base::win::ScopedBstr(url_wstring.c_str()),
                                     flags, base::win::ScopedBstr(L"_blank"));
-    // We can DCHECK here because navigating to a new tab shouldn't fail as
-    // described in the comment at the bottom of CeeeExecutor::Navigate().
-    DCHECK(SUCCEEDED(hr)) << "Failed to create tab. " << com::LogHr(hr);
     if (FAILED(hr)) {
+      // Log the error without DCHECKING There are legit reasons for Navigate
+      // to fail, as explained in comments in CeeeExecutor::Navigate.
+      // TODO(motek@chromium.org) See why exactly we fail here in some
+      // integration tests.
+      LOG(WARNING) << "Failed to create tab. " << com::LogHr(hr);

[mad-corp, 2010/12/14 13:38:20]

This should be at least ERROR... And I actually think the DCHECK IS important
here... If we have cases where it is legit to fail, we should DCHECK on those
cases (e.g., the window into which we are attempting to create a new tab is
going away)... It could also be that it's the tab we are trying to use as the
source of the navigation that is going away, and we may be able to use another
one...

I think a TODO isn't enough here, we should file a bug for this... And bump up
the error level... If the DCHECK is problematic, then LOG(ERROR | FATAL)...

       result->PostError("Internal error while trying to create tab.");
       return;
     }
   }
 
   // And now we must wait for the new tab to be created before we can respond.
   dispatcher->RegisterEphemeralEventHandler(
       ext_event_names::kOnTabCreated,
       CreateTab::ContinueExecution,
       // We don't want to destroy the result in the scoped_ptr when we pass
@@ skipping 347 matching lines @@
   ::SysFreeString(title);
   title = NULL;
   ::SysFreeString(fav_icon_url);
   fav_icon_url = NULL;
 
   status = kCeeeTabStatusLoading;
   protected_mode = FALSE;
 }
 
 }  // namespace tab_api