Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: ceee/ie/plugin/bho/executor.cc

Issue 5751001: Replace DCHECKs on InserCode and Navigate paths with LOG(ERROR) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // CeeeExecutor implementation 5 // CeeeExecutor implementation
6 // 6 //
7 // We use interfaces named ITabWindowManager and ITabWindow 7 // We use interfaces named ITabWindowManager and ITabWindow
8 // (documented at 8 // (documented at
9 // http://www.geoffchappell.com/viewer.htm?doc=studies/windows/ie/ieframe/interf aces/itabwindowmanager.htm 9 // http://www.geoffchappell.com/viewer.htm?doc=studies/windows/ie/ieframe/interf aces/itabwindowmanager.htm
10 // and 10 // and
(...skipping 859 matching lines...) Expand 10 before | Expand all | Expand 10 after
870 hr = GetSite(IID_IFrameEventHandlerHost, 870 hr = GetSite(IID_IFrameEventHandlerHost,
871 reinterpret_cast<void**>(&frame_handler_host)); 871 reinterpret_cast<void**>(&frame_handler_host));
872 if (FAILED(hr)) { 872 if (FAILED(hr)) {
873 NOTREACHED() << "No frame event handler host for executor. " 873 NOTREACHED() << "No frame event handler host for executor. "
874 << com::LogHr(hr); 874 << com::LogHr(hr);
875 return hr; 875 return hr;
876 } 876 }
877 877
878 hr = frame_handler_host->InsertCode(code, file, all_frames, type); 878 hr = frame_handler_host->InsertCode(code, file, all_frames, type);
879 if (FAILED(hr)) { 879 if (FAILED(hr)) {
880 NOTREACHED() << "Failed to insert code. " << com::LogHr(hr); 880 LOG(ERROR) << "Failed to insert code. " << com::LogHr(hr);
881 return hr; 881 return hr;
882 } 882 }
883 883
884 return S_OK; 884 return S_OK;
885 } 885 }
886 886
887 HRESULT CeeeExecutor::GetCookieValue(BSTR url, BSTR name, BSTR* value) { 887 HRESULT CeeeExecutor::GetCookieValue(BSTR url, BSTR name, BSTR* value) {
888 DCHECK(value); 888 DCHECK(value);
889 if (!value) 889 if (!value)
890 return E_POINTER; 890 return E_POINTER;
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
1019 1019
1020 STDMETHODIMP CeeeExecutor::OnTopFrameBeforeNavigate(BSTR url) { 1020 STDMETHODIMP CeeeExecutor::OnTopFrameBeforeNavigate(BSTR url) {
1021 DCHECK(infobar_manager_ != NULL) << "infobar_manager_ is not initialized"; 1021 DCHECK(infobar_manager_ != NULL) << "infobar_manager_ is not initialized";
1022 if (infobar_manager_ == NULL) 1022 if (infobar_manager_ == NULL)
1023 return E_FAIL; 1023 return E_FAIL;
1024 1024
1025 // According to the specification, tab navigation closes the infobar. 1025 // According to the specification, tab navigation closes the infobar.
1026 infobar_manager_->HideAll(); 1026 infobar_manager_->HideAll();
1027 return S_OK; 1027 return S_OK;
1028 } 1028 }
OLDNEW
« ceee/ie/plugin/bho/browser_helper_object.cc ('K') | « ceee/ie/plugin/bho/browser_helper_object.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698