Replace DCHECKs on InserCode and Navigate paths with LOG(ERROR)

ceee/ie/plugin/bho/browser_helper_object.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // IE browser helper object implementation.
 #include "ceee/ie/plugin/bho/browser_helper_object.h"
 
 #include <atlsafe.h>
 #include <shlguid.h>
 
@@ skipping 151 matching lines @@
   default:
     counter_name += 'x';
     break;
   }
   VLOG(1) << counter_name << "=" << time;
   broker_rpc().SendUmaHistogramTimes(counter_name.c_str(), time);
 }
 
 STDMETHODIMP BrowserHelperObject::SetSite(IUnknown* site) {
   typedef IObjectWithSiteImpl<BrowserHelperObject> SuperSite;
+  LOG(INFO) << "BHO's set site called with " << site;

[mad-corp, 2010/12/14 13:38:20]

Please use VLOG(1)

 
   // From experience, we know the site may be set multiple times.
   // Let's ignore second and subsequent set or unset.
   if (site != NULL && m_spUnkSite.p != NULL ||
       site == NULL && m_spUnkSite.p == NULL ) {
     LOG(WARNING) << "Duplicate call to SetSite, previous site "
                  << m_spUnkSite.p << " new site " << site;
     return S_OK;
   }
 
@@ skipping 1296 matching lines @@
       DCHECK(it->second != NULL);
       if (it->second != NULL) {
         HRESULT hr = it->second->InsertCode(code, file, type);
         DCHECK(SUCCEEDED(hr)) << "IFrameEventHandler::InsertCode()" <<
             com::LogHr(hr);
       }
     }
   } else if (web_browser_ != NULL) {
     ScopedFrameEventHandlerPtr handler;
     HRESULT hr = GetBrowserHandler(web_browser_, handler.Receive());
-    DCHECK(SUCCEEDED(hr) && handler != NULL) << com::LogHr(hr);
+    LOG_IF(ERROR, FAILED(hr) || handler == NULL) <<
+        "GetBrowserHandler fails in InsertCode: " << com::LogHr(hr);
+    if (FAILED(hr))
+      return hr;
 
     if (handler != NULL) {
       hr = handler->InsertCode(code, file, type);
       // TODO(joi@chromium.org) We don't DCHECK for now, because Chrome may have
       // multiple extensions loaded whereas CEEE only knows about a single
       // extension.  Clean this up once we support multiple extensions.
     }
   }
   return S_OK;
 }
@@ skipping 135 matching lines @@
     return S_FALSE;
   } else {
     return SendEventToBrokerImpl(event_name, event_args);
   }
 }
 
 HRESULT BrowserHelperObject::SendEventToBrokerImpl(
     const std::string& event_name, const std::string& event_args) {
   return broker_rpc().FireEvent(event_name.c_str(), event_args.c_str());
 }