Issue 521018: A bunch of unit tests for GLES2

Issue 521018: A bunch of unit tests for GLES2 (Closed)

Created:
10 years, 11 months ago by greggman

Modified:
9 years, 7 months ago

Reviewers:

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

A bunch of unit tests for GLES2 TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35495

Patch Set 5 : '' #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4524 lines, -889 lines)			Patch
M	gpu/command_buffer/build_gles2_cmd_buffer.py	View	1 2 3	61 chunks	+1202 lines, -470 lines	0 comments	Download
M	gpu/command_buffer/client/gles2_c_lib_autogen.h	View	1 2 3	12 chunks	+39 lines, -44 lines	0 comments	Download
M	gpu/command_buffer/client/gles2_cmd_helper_autogen.h	View	1 2 3	3 chunks	+14 lines, -4 lines	0 comments	Download
M	gpu/command_buffer/client/gles2_implementation_autogen.h	View	1 2 3	4 chunks	+10 lines, -1 line	0 comments	Download
M	gpu/command_buffer/client/gles2_implementation_gen.h	View	1 2 3	2 chunks	+5 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/common/gles2_cmd_format_autogen.h	View	1 2 3	3 chunks	+23 lines, -16 lines	0 comments	Download
M	gpu/command_buffer/common/gles2_cmd_format_test_autogen.h	View	1 2 3	232 chunks	+319 lines, -308 lines	0 comments	Download
M	gpu/command_buffer/common/gles2_cmd_id_test_autogen.h	View	1 2 3	2 chunks	+10 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/common/gles2_cmd_ids_autogen.h	View	1 2 3	2 chunks	+9 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/gl_interface.h	View	1 2 3	1 chunk	+21 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.h	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View	1 2 3 4	14 chunks	+47 lines, -12 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_autogen.h	View	1 2 3	18 chunks	+56 lines, -10 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc	View	1 2 3 4	2 chunks	+177 lines, -18 lines	0 comments	Download
A	gpu/command_buffer/service/gles2_cmd_decoder_unittest_autogen.h	View		1 chunk	+2558 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_validation_autogen.h	View	1 2 3	3 chunks	+11 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h	View	1 2 3	4 chunks	+19 lines, -2 lines	0 comments	Download
M	gpu/gpu.gyp	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

greggman

I hope I'm not being too impatient but just in case you didn't see this ...

10 years, 11 months ago (2010-01-04 21:32:23 UTC) #2

apatrick

LGTM http://codereview.chromium.org/521018/diff/8001/8007 File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): http://codereview.chromium.org/521018/diff/8001/8007#newcode835 gpu/command_buffer/service/gles2_cmd_decoder.cc:835: DCHECK(false); // should never get here. NOTREACHED() http://codereview.chromium.org/521018/diff/8001/8006 ...

10 years, 11 months ago (2010-01-04 22:15:05 UTC) #3

tavares.gregg_gmail.com

10 years, 9 months ago (2010-03-07 05:28:31 UTC) #4

http://codereview.chromium.org/521018/diff/8001/8006
File gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc (right):

http://codereview.chromium.org/521018/diff/8001/8006#newcode172
gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc:172: GLES2Decoder*
decoder_;
Would it make sense for this to be a scoped_ptr?

Expand Messages | Collapse Messages