Issue 387012: Split *AndAdjustOffset() functions into their own header, to restore utf_stri...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 387012: Split *AndAdjustOffset() functions into their own header, to restore utf_stri... (Closed)

Created:
11 years, 1 month ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Split *AndAdjustOffset() functions into their own header, to restore utf_string_conversions.h to a simple, readable state. BUG=4010 TEST=none

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+176 lines, -1061 lines)			Patch
M	base/base.gyp	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	base/i18n/icu_string_conversions.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
A +	base/utf_offset_string_conversions.h	View		2 chunks	+12 lines, -59 lines	0 comments	Download
A +	base/utf_offset_string_conversions.cc	View		7 chunks	+13 lines, -263 lines	0 comments	Download
A +	base/utf_offset_string_conversions_unittest.cc	View	1 2 3	2 chunks	+4 lines, -196 lines	0 comments	Download
A	base/utf_string_conversion_utils.h	View	3	1 chunk	+86 lines, -0 lines	0 comments	Download
A +	base/utf_string_conversion_utils.cc	View	1 2 3	9 chunks	+23 lines, -247 lines	0 comments	Download
M	base/utf_string_conversions.h	View		2 chunks	+7 lines, -32 lines	0 comments	Download
M	base/utf_string_conversions.cc	View		8 chunks	+22 lines, -218 lines	0 comments	Download
M	base/utf_string_conversions_unittest.cc	View		1 chunk	+0 lines, -43 lines	0 comments	Download
M	net/base/escape.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	net/base/net_util.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Peter Kasting

Reviewers: brettw, Description: Split *AndAdjustOffset() functions into their own header, to restore utf_string_conversions.h to a ...

11 years, 1 month ago (2009-11-11 02:59:31 UTC) #2

LGTM