Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 368001: Second patch in making destructors of refcounted objects private. (Closed)

Created:
11 years, 1 month ago by jam
Modified:
9 years, 7 months ago
Reviewers:
eroman
CC:
chromium-reviews_googlegroups.com, John Grabowski, darin (slow to review), pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Second patch in making destructors of refcounted objects private. BUG=26749 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31165

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 9
Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -133 lines) Patch
M net/base/address_list.h View 1 1 chunk +5 lines, -1 line 0 comments Download
M net/base/cert_verifier.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M net/base/cookie_monster.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/cookie_monster_perftest.cc View 1 3 chunks +8 lines, -8 lines 0 comments Download
M net/base/cookie_store.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M net/base/directory_lister.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M net/base/fixed_host_resolver.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/base/host_cache.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M net/base/host_resolver.h View 1 2 chunks +7 lines, -5 lines 0 comments Download
M net/base/host_resolver_impl.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M net/base/host_resolver_impl.cc View 1 2 chunks +7 lines, -5 lines 0 comments Download
M net/base/host_resolver_impl_unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/base/host_resolver_proc.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M net/base/io_buffer.h View 1 8 chunks +22 lines, -12 lines 0 comments Download
M net/base/listen_socket.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M net/base/listen_socket_unittest.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M net/base/load_log.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M net/base/mock_host_resolver.h View 1 7 chunks +12 lines, -4 lines 0 comments Download
M net/base/sdch_manager.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M net/base/ssl_cert_request_info.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M net/base/ssl_config_service.h View 1 2 chunks +5 lines, -2 lines 0 comments Download
M net/base/ssl_config_service_defaults.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M net/base/ssl_config_service_mac.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M net/base/ssl_config_service_win.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M net/base/strict_transport_security_state.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M net/base/telnet_server.h View 1 2 chunks +1 line, -1 line 0 comments Download
M net/base/telnet_server_unittest.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M net/base/test_completion_callback_unittest.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M net/base/upload_data.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M net/disk_cache/file_posix.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M net/disk_cache/mapped_file.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M net/disk_cache/sparse_control.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M net/flip/flip_session.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M net/flip/flip_session_pool.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M net/ftp/ftp_network_session.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M net/http/http_auth_cache_unittest.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M net/http/http_auth_handler.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M net/http/http_auth_handler_basic.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/http/http_auth_handler_digest.h View 1 1 chunk +2 lines, -0 lines 2 comments Download
M net/http/http_auth_handler_ntlm.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_cache_unittest.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M net/http/http_network_session.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M net/ocsp/nss_ocsp.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M net/proxy/mock_proxy_resolver.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M net/proxy/proxy_config_service_linux.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M net/proxy/proxy_resolver_js_bindings.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M net/proxy/proxy_resolver_js_bindings_unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/proxy/proxy_script_fetcher_unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/proxy/proxy_service.h View 1 3 chunks +8 lines, -2 lines 2 comments Download
M net/proxy/proxy_service.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M net/proxy/single_threaded_proxy_resolver.cc View 1 3 chunks +11 lines, -0 lines 0 comments Download
M net/socket/client_socket_pool_base.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M net/socket/client_socket_pool_base_unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/socket/tcp_client_socket_win.cc View 1 2 chunks +4 lines, -1 line 2 comments Download
M net/socket/tcp_pinger.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M net/socket_stream/socket_stream.h View 1 2 chunks +6 lines, -2 lines 0 comments Download
M net/tools/fetch/fetch_client.cc View 1 1 chunk +1 line, -1 line 1 comment Download
M net/tools/fetch/http_listen_socket.h View 1 2 chunks +6 lines, -4 lines 0 comments Download
MM net/tools/fetch/http_session.h View 1 1 chunk +27 lines, -27 lines 0 comments Download
M net/url_request/url_request_about_job.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/url_request/url_request_data_job.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M net/url_request/url_request_error_job.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/url_request/url_request_file_dir_job.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M net/url_request/url_request_file_job.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M net/url_request/url_request_file_job.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M net/url_request/url_request_ftp_job.h View 1 2 chunks +2 lines, -2 lines 2 comments Download
M net/url_request/url_request_http_job.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M net/url_request/url_request_inet_job.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M net/url_request/url_request_job.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M net/url_request/url_request_new_ftp_job.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_redirect_job.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/url_request/url_request_simple_job.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/url_request/url_request_test_job.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_unittest.h View 1 6 chunks +13 lines, -6 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 1 4 chunks +7 lines, -0 lines 0 comments Download
M net/url_request/url_request_view_net_internals_job.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/websockets/websocket_throttle.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
11 years, 1 month ago (2009-11-05 20:14:00 UTC) #1
eroman
LGTM! http://codereview.chromium.org/368001/diff/1040/197 File net/http/http_auth_handler_digest.h (right): http://codereview.chromium.org/368001/diff/1040/197#newcode34 Line 34: ~HttpAuthHandlerDigest() {} nit: move this below the ...
11 years, 1 month ago (2009-11-05 20:52:19 UTC) #2
jam
11 years, 1 month ago (2009-11-05 21:56:02 UTC) #3 
http://codereview.chromium.org/368001/diff/1040/197
File net/http/http_auth_handler_digest.h (right):

http://codereview.chromium.org/368001/diff/1040/197#newcode34
Line 34: ~HttpAuthHandlerDigest() {}
On 2009/11/05 20:52:19, eroman wrote:
> nit: move this below the enums.

Done.

http://codereview.chromium.org/368001/diff/1040/202
File net/proxy/proxy_service.h (right):

http://codereview.chromium.org/368001/diff/1040/202#newcode161
Line 161: ~ProxyService();
On 2009/11/05 20:52:19, eroman wrote:
> nit: move this below the typedef

Done.

http://codereview.chromium.org/368001/diff/1040/210
File net/socket/tcp_client_socket_win.cc (right):

http://codereview.chromium.org/368001/diff/1040/210#newcode165
Line 165: ~Core();
On 2009/11/05 20:52:19, eroman wrote:
> nit: move this after the inner class definitions.

Done.

http://codereview.chromium.org/368001/diff/1040/237
File net/url_request/url_request_ftp_job.h (right):

http://codereview.chromium.org/368001/diff/1040/237#newcode39
Line 39: ~URLRequestFtpJob();
On 2009/11/05 20:52:19, eroman wrote:
> was it intentional to remove the virtual keyword?
> (shouldn't matter, just curious).

it wasn't needed, but I'll keep it the way it was and put it back

Powered by Google App Engine
This is Rietveld 408576698