Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/url_request/url_request_ftp_job.h

Issue 368001: Second patch in making destructors of refcounted objects private. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/tools/fetch/fetch_client.cc ('K') | « net/url_request/url_request_file_job.cc ('k') | net/url_request/url_request_http_job.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_ftp_job.h
===================================================================
--- net/url_request/url_request_ftp_job.h (revision 31079)
+++ net/url_request/url_request_ftp_job.h (working copy)
@@ -14,8 +14,6 @@
public:
static URLRequestJob* Factory(URLRequest* request, const std::string& scheme);
- virtual ~URLRequestFtpJob();
-
// URLRequestJob methods:
virtual void Start();
virtual bool GetMimeType(std::string* mime_type) const;
@@ -38,6 +36,8 @@
virtual bool IsRedirectResponse(GURL* location, int* http_status_code);
private:
+ ~URLRequestFtpJob();
eroman 2009/11/05 20:52:19 was it intentional to remove the virtual keyword?
jam 2009/11/05 21:56:02 it wasn't needed, but I'll keep it the way it was
+
// Called after InternetConnect successfully connects to server.
void OnConnect();
« net/tools/fetch/fetch_client.cc ('K') | « net/url_request/url_request_file_job.cc ('k') | net/url_request/url_request_http_job.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698