Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Unified Diff: net/socket/client_socket_pool_base.h

Issue 368001: Second patch in making destructors of refcounted objects private. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/client_socket_pool_base.h
===================================================================
--- net/socket/client_socket_pool_base.h (revision 31079)
+++ net/socket/client_socket_pool_base.h (working copy)
@@ -168,8 +168,6 @@
base::TimeDelta used_idle_socket_timeout,
ConnectJobFactory* connect_job_factory);
- ~ClientSocketPoolBaseHelper();
-
// See ClientSocketPool::RequestSocket for documentation on this function.
// Note that |request| must be heap allocated. If ERR_IO_PENDING is returned,
// then ClientSocketPoolBaseHelper takes ownership of |request|.
@@ -222,6 +220,10 @@
void CleanupIdleSockets(bool force);
private:
+ friend class base::RefCounted<ClientSocketPoolBaseHelper>;
+
+ ~ClientSocketPoolBaseHelper();
+
// Entry for a persistent socket which became idle at time |start_time|.
struct IdleSocket {
IdleSocket() : socket(NULL), used(false) {}

Powered by Google App Engine
This is Rietveld 408576698