Second patch in making destructors of refcounted objects private.

net/socket/tcp_client_socket_win.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/socket/tcp_client_socket_win.h"
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/field_trial.h"  // for SlowStart trial
 #include "base/memory_debug.h"
@@ skipping 108 matching lines @@
 //-----------------------------------------------------------------------------
 
 // This class encapsulates all the state that has to be preserved as long as
 // there is a network IO operation in progress. If the owner TCPClientSocketWin
 // is destroyed while an operation is in progress, the Core is detached and it
 // lives until the operation completes and the OS doesn't reference any resource
 // declared on this class anymore.
 class TCPClientSocketWin::Core : public base::RefCounted<Core> {
  public:
   explicit Core(TCPClientSocketWin* socket);
-  ~Core();
 
   // Start watching for the end of a read or write operation.
   void WatchForRead();
   void WatchForWrite();
 
   // The TCPClientSocketWin is going away.
   void Detach() { socket_ = NULL; }
 
   // The separate OVERLAPPED variables for asynchronous operation.
   // |read_overlapped_| is used for both Connect() and Read().
@@ skipping 14 matching lines @@
       return size;
 
     if (slow_start_throttle_ < kMaxSlowStartThrottle) {
       size = std::min(size, slow_start_throttle_);
       slow_start_throttle_ *= 2;
     }
     return size;
   }
 
  private:
+  friend class base::RefCounted<Core>;
+
+  ~Core();

[eroman, 2009/11/05 20:52:19]

nit: move this after the inner class definitions.

[jam, 2009/11/05 21:56:02]

Done.

+
   class ReadDelegate : public base::ObjectWatcher::Delegate {
    public:
     explicit ReadDelegate(Core* core) : core_(core) {}
     virtual ~ReadDelegate() {}
 
     // base::ObjectWatcher::Delegate methods:
     virtual void OnObjectSignaled(HANDLE object);
 
    private:
     Core* const core_;
@@ skipping 517 matching lines @@
   BOOL ok = WSAGetOverlappedResult(socket_, &core_->write_overlapped_,
                                    &num_bytes, FALSE, &flags);
   WSAResetEvent(core_->write_overlapped_.hEvent);
   TRACE_EVENT_END("socket.write", this, StringPrintf("%d bytes", num_bytes));
   waiting_write_ = false;
   core_->write_iobuffer_ = NULL;
   DoWriteCallback(ok ? num_bytes : MapWinsockError(WSAGetLastError()));
 }
 
 }  // namespace net